Updated Ground Alignment and Add Local Map-Based Evaluation of Closures #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

saurabh1002 merged 4 commits into main from gupta/update_ground_alignment_and_eval

Sep 30, 2025

Collaborator

saurabh1002 commented Sep 29, 2025

Add a normal-based filtering for better ground alignment for the BEV projections, this changes API call to the get_closures method
Use local map-based ground truth closures for the PR-curve evaluations, this changes API call to the EvaluationPipeline class and its methods
Minor changes in the data handling within the pipeline.py file


          modify evaluations for local map gt closures, update pipeline

9595d74

saurabh1002 requested review from benemer, mehermvr and tizianoGuadagnino as code owners

September 29, 2025 12:01

mehermvr reviewed

View reviewed changes

cpp/map_closures/GroundAlign.hpp Outdated Show resolved Hide resolved

mehermvr reviewed

View reviewed changes

cpp/map_closures/VoxelMap.cpp Show resolved Hide resolved

mehermvr reviewed

View reviewed changes

cpp/map_closures/VoxelMap.cpp Outdated Show resolved Hide resolved

mehermvr reviewed

View reviewed changes

cpp/map_closures/VoxelMap.cpp Show resolved Hide resolved

mehermvr reviewed

View reviewed changes

cpp/map_closures/VoxelMap.hpp Outdated Show resolved Hide resolved

saurabh1002 added 3 commits

September 29, 2025 14:54


          make types explicit, fix alias declarations inside namespaces

c6fc1bd


          remove unnecessary inlines

017e99a


          remove the template cast which is not needed

f46c915

Member

mehermvr commented Sep 29, 2025

api changes probably should get a major version bump (if we stick to semver strictly)

mehermvr approved these changes

View reviewed changes

saurabh1002 merged commit bce4189 into main

18 checks passed

saurabh1002 added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels