Remove unused MATLAB MSP hfun #250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also aligns the hfuns so that the MATLAB hfuns are a proper subset of the Python hfuns, which was deemed acceptable. Clean up MSP docs to reflect this.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #250 +/- ##
==========================================
- Coverage 94.53% 94.41% -0.12%
==========================================
Files 94 93 -1
Lines 3642 3618 -24
==========================================
- Hits 3443 3416 -27
- Misses 199 202 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hopefully this will revert some of the loss in code coverage seen for this branch.
jared321
changed the title
jmlarson1
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Self-review
Note that code coverage by line has dropped by a small amount due to no longer testing this hfun in the MSP benchmark test. The only noteworthy impact of this is that line 420 of
pounders.mis no longer tested. Note that the analogous line inpython.py(Line 324) is not covered onmain. While this is unfortunate, we accept this loss since that test was never intentionally designed to hit that line and there's always the possibility that small effects could cause that line to be untested as well.