Clean README and enhanced install instructions for protobuf in Docu#715
Clean README and enhanced install instructions for protobuf in Docu#715
Conversation
|
Use placeholder for version |
6eb143b to
8d887f8
Compare
|
@pmai, could you please provide the further details on proper linker flags in addition to the instructions in the new file installing_prerequisites.adoc? |
|
@philipwindecker Thanks a lot for your support with documentation references and your review! |
philipwindecker
left a comment
There was a problem hiding this comment.
Review done. I would recommend using description lists instead of bold formatting because they provide more consistent styling. See https://docs.asciidoctor.org/asciidoc/latest/lists/description/
https://docs.asciidoctor.org/asciidoc/latest/lists/horizontal/
Alternatively, using subsections (level 2 i.e. ===) would help with automatically creating anchors and entries in the toc.
|
CCB 2023-05-22: Merge as-is, conflicts to be resolved @pmai |
9989c54 to
6cecadd
Compare
Signed-off-by: Philipp Rosenberger <philipp.rosenberger@persival.de>
for setting up osi Signed-off-by: Philip Windecker <philip.windecker@avenyr.de>
Signed-off-by: Philipp Rosenberger <philipp.rosenberger@partner.bmw.de>
6cecadd to
fefe981
Compare
Changes have been performed as requested
Reference to a related issue in the repository
Relates to
Add a description
We need better install instructions for static / dynamic linking, so this PR should enhance the README for this.
More explanation should then follow in the OSI documentation, I guess?
Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board: