Conversation
…king Signed-off-by: Philipp Rosenberger <philipp.rosenberger@persival.de>
PhRosenberger
added
the
documentation
PhRosenberger
requested review from
ClemensLinnhoff,
jruebsam,
philipwindecker and
pmai
Contributor
|
consider placeholder for version |
Signed-off-by: Philipp Rosenberger <philipp.rosenberger@partner.bmw.de>
PhRosenberger
force-pushed
the
87-file-already-exists-in-database-windows
branch
from
4c1fa0e to
6df9126
Compare
Contributor
Author
|
Install instructions are located only at one place in the documentation now. OSMP docu (part) just has to link to it then. |
pmai
requested changes
Mar 13, 2023
(empty line before title can have technical implications) Signed-off-by: Philip Windecker <philip.windecker@avenyr.de>
PhRosenberger
added
the
ReadyForCCBReview
Signed-off-by: Pierre R. Mai <pmai@pmsf.de> Co-authored-by: Philip Windecker <95633467+philipwindecker@users.noreply.github.com>
pmai
approved these changes
Mar 27, 2023
Contributor
|
CCB on 2023-03-27: Merge as-is. |
pmai
added
ReadyToMerge
and removed
ReadyForCCBReview
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference to a related issue in the repository
Relates to
Add a description
We need better install instructions for static / dynamic linking, so this PR should enhance the README for this.
More explanation should then follow in the OSI documentation, I guess?
Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board: