feat(contrib): multi-wallet (WalletConnect v2 + MetaMask) + demo #845
+546
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add modular wallet adapter interface (connect/getAddress/signMessage/sendTransaction) - Providers: WalletConnect v2 (QR) & MetaMask (EIP-1193) - Demo (Sepolia): Connect → Sign → Send Tx - Include README, .env.example, and .gitignore
…ject structure - Add abstract ProviderBase interface in src/providers/base.py - Add CoinbaseProvider with lazy CDP SDK loading - Add MetaMaskProvider for signature verification - Add comprehensive tests for both providers - Add README documenting provider usage and integration Addresses feedback from PR OpenMind#428 to follow coinbase provider pattern
github-actions
bot
added
robotics
- Update imports from 'providers.coinbase' to 'src.providers.coinbase_provider' - Update imports from 'providers.metamask' to 'src.providers.metamask_provider' - Fixes CI/CD test failures (ModuleNotFoundError)
- Update string literal from 'providers.metamask.Account' to 'src.providers.metamask_provider.Account' - Fixes test_metamask_verify_signature monkeypatch target
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Implements modular wallet adapter interface with two providers following project structure standards. This PR addresses feedback from #456 and provides a clean, maintainable architecture.
Changes
providers/tosrc/providers/following project structurecoinbase.py→coinbase_provider.pymetamask.py→metamask_provider.pysrc.actions,src.backgrounds,src.inputs,src.llm, etc.)wallet_coinbase.pycontrib/multi-wallet/directory (non-compliant TypeScript code)src/providers/init.pyandfactory.pyimportsDemo app
Demonstrates: Connect → Sign → Send Tx on Sepolia (
sepolia:11155111)Demo videos
How to run
apps/demo/.env.example→apps/demo/.envand setVITE_WC_PROJECT_IDapps/demo:Testing
create_provider('coinbase', {...})andcreate_provider('metamask')Addresses
Feedback from @Prachi1615 on #456
Additional Information
src/providers/with proper naming