feat: implement selective hot-reload with watchdog #2219
+2,239
−481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependencies
- Update om1-modules to commit eedbb2be (fixes missing AudioOutputLiveStream) - Relax vulture constraint from ==2.10 to >=2.10 (allows vulture 2.14+ required by om1-modules) - These changes fix CI/CD test failures unrelated to hot-reload feature
- Update test_reload_config_success to use ConfigChange with proper parameters - Update test_run_with_hot_reload_enabled to mock ConfigFileWatcher instead of polling - Update test_run_handles_none_cortex_loop_task_on_reload to handle CancelledError - Remove AsyncMock warning by using regular Mock for non-async start method
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
#984
Description
Implements selective hot-reload functionality using watchdog library for real-time configuration file monitoring, replacing the previous polling-based approach.
Changes
Hot-Reload Implementation
watchdogdependency for real-time file monitoringConfigFileWatcherfor config file monitoring with debouncingHotReloadManagerfor selective configuration updatesHOT_RELOAD— apply changes without restartVALIDATE_FIRST— validate before applyingRESTART_REQUIRED— requires full system restartmodel,provider,api_key) as restart-requiredCortexRuntimeto use watchdog instead of pollingcheck_intervalparameterconfig_watchermoduleActionOrchestratorto support config propagation viaupdate_config()methodBug Fixes (found during development)
om1-modulesto commiteedbb2be(resolves missingAudioOutputLiveStreamimport)vultureconstraint from==2.10to>=2.10(resolves conflict with om1-modules requirement for vulture >=2.14)These dependency fixes resolve existing CI/CD failures that were blocking all PRs.