fix: validate camera frame before processing in VLM input plugins #2208
+82
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cap.read() can return (False, None) when the camera drops a frame, which happens during simulation startup with virtual camera devices or when a physical camera temporarily loses connection. Three plugins passed the unchecked frame directly to model inference, causing crashes. - Add ret/frame validation in vlm_local_yolo, vlm_coco_local, and webcam_to_face_emotion to skip dropped frames gracefully - Initialize cam_third with a safe default in vlm_local_yolo so _raw_to_text does not raise AttributeError when no camera is present - Add tests for frame validation and safe initialization Closes OpenMind#2207
github-actions
bot
added
robotics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
cap.read()returns(ret, frame)butretwas never checked in three VLM input plugins. When the camera drops a frame (ret=False, frame=None), theNoneframe gets passed to model inference and crashes the runtime.vlm_local_yolo.py,vlm_coco_local.py, andwebcam_to_face_emotion.py. The correct pattern already exists inunitree_realsense_dev_vlm_provider.py— this PR brings the other plugins in line.cam_thirdwith a safe default invlm_local_yoloso_raw_to_textdoesn't raiseAttributeErrorwhen no camera is present.This is especially relevant for simulation environments (Gazebo, Isaac Sim) where virtual camera devices may not have frames ready immediately at startup.
Closes #2207
Test plan
test_poll_returns_none_on_failed_frame_readfor YOLO plugintest_poll_returns_none_on_none_framefor YOLO plugin (ret=True but frame=None edge case)test_cam_third_initialized_without_camerafor safe default initializationtest_poll_returns_none_on_failed_frame_readfor COCO plugin