fix: correct copy-paste error messages and inconsistent logger usage #2200
+53
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix wrong exception messages in rplidar_driver.py: get_health() and start() both incorrectly used "Wrong get_info reply length" copied from get_info() - Fix inconsistent logger usage in unitree_realsense_dev_vlm_provider.py: two calls used module-level logging instead of the file's logger instance
0xbyt4
approved these changes
Feb 10, 2026
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
rplidar_driver.py:get_health()andstart()both incorrectly raised"Wrong get_info reply length"copied fromget_info(), making debugging misleadingunitree_realsense_dev_vlm_provider.py: two calls used module-levellogginginstead of the file'sloggerinstance, causing logs to bypass the configured logger hierarchyFiles changed
src/providers/rplidar_driver.py— line 312, 380src/providers/unitree_realsense_dev_vlm_provider.py— line 320, 333Test plan