-
Notifications
You must be signed in to change notification settings - Fork 940
Add watchdog-based selective hot-reload with safe patch application #2182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
farukk77
wants to merge
16
commits into
OpenMind:main
Choose a base branch
from
farukk77:feat/984-watchdog-selective-hot-reload
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add watchdog-based selective hot-reload with safe patch application #2182
farukk77
wants to merge
16
commits into
OpenMind:main
from
farukk77:feat/984-watchdog-selective-hot-reload
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor CortexRuntime into ModeCortexRuntime to support mode-aware functionality. Introduce mode management and configuration handling for dynamic operational modes.
Updated config provider to use json5 for dumping and improved temp file handling.
Add extensive tests for mode transitions in cortex runtime, covering various scenarios including input triggers, emergency mode handling, and transition callbacks.
Add unit tests for ModeCortexRuntime class including hot reload functionality and mode transitions.
Add tests for CortexRuntime including hot reload functionality and configuration change detection.
Refactor ModeCortexRuntime to CortexRuntime and update configuration handling for single mode.
Added support for hot-reloading configuration using a watchdog mechanism. Enhanced the reload logic to apply partial updates based on changes in the configuration file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
config
Configuration files
dependencies
Pull requests that update a dependency file
python
Python code
robotics
Robotics code changes
tests
Test files
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR upgrades runtime hot-reload from polling-based mtime checks to watchdog file-system events (with polling fallback), and moves “partial vs full reload” decisions into the runtime via a field-level patch.
Why
Changes
Key files
Verification