Add error handling to ZenohListenerProvider.stop #2006
+28
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
robotics
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Collaborator
|
Hi @aydnOktay can you fix lint errors |
Contributor
Author
done sir , check pls @0xbyt4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing provider cleanup methods, I noticed that ZenohListenerProvider.stop() was calling session.close() without any exception handling, which could cause the provider to crash if the session close operation fails. I also noticed the docstring incorrectly mentioned stopping a background thread when no thread actually exists in this provider. I've added proper try-except-finally error handling similar to ContextProvider , ensuring that exceptions during session closure are caught and logged, and the session is always set to None in the finally block for proper cleanup. The docstring has also been corrected to accurately reflect what the method does