Add litellm_proxy/gpt-oss-20b to resolve_model_config.py#1906
Add litellm_proxy/gpt-oss-20b to resolve_model_config.py#1906juanmichelini wants to merge 3 commits intomainfrom
Conversation
- Add gpt-oss-20b model with litellm_proxy/gpt-oss-20b to MODELS dictionary - Add gpt-oss-20b to EXPECTED_MODELS list in tests - Add test_gpt_oss_20b_config test to verify the model configuration Fixes #1905 Co-authored-by: openhands <[email protected]>
all-hands-bot
left a comment
There was a problem hiding this comment.
Overall, this PR looks good! The model configuration follows the existing patterns and the test coverage is appropriate. I have one minor suggestion about naming consistency.
| }, | ||
| "gpt-oss-20b": { | ||
| "id": "gpt-oss-20b", | ||
| "display_name": "GPT OSS 20B", |
There was a problem hiding this comment.
🟡 Suggestion: Consider using "GPT-OSS-20B" for the display name to maintain consistency with other GPT models like "GPT-5.2" and "GPT-5.2 Codex" which use hyphens. However, if "GPT OSS 20B" is the official name, the current format is fine.
|
Looks like there are a few issues preventing this PR from being merged!
If you'd like me to help, just leave a comment, like or Feel free to include any additional details that might help me get this PR into a better state. You can manage your notification settings |
Summary
This PR adds the
gpt-oss-20bmodel with idgpt-oss-20bto the expected models inresolve_model_config.py, as requested in issue #1905.Changes:
gpt-oss-20bmodel configuration to theMODELSdictionary withlitellm_proxy/gpt-oss-20bas the model pathgpt-oss-20bto theEXPECTED_MODELSlist in the test filetest_gpt_oss_20b_configtest to verify the model configurationFixes #1905
Checklist
@juanmichelini can click here to continue refining the PR
Agent Server images for this PR
• GHCR package: https://github.com/OpenHands/agent-sdk/pkgs/container/agent-server
Variants & Base Images
eclipse-temurin:17-jdknikolaik/python-nodejs:python3.13-nodejs22golang:1.21-bookwormPull (multi-arch manifest)
# Each variant is a multi-arch manifest supporting both amd64 and arm64 docker pull ghcr.io/openhands/agent-server:45b772b-pythonRun
All tags pushed for this build
About Multi-Architecture Support
45b772b-python) is a multi-arch manifest supporting both amd64 and arm6445b772b-python-amd64) are also available if needed