Skip to content

Conversation

@catenacyber
Copy link
Contributor

Link to ticket: https://redmine.openinfosecfoundation.org/issues/
Should I create a specific one ?

Describe changes:

  • Move ssh detect code to pure rust
  • bindgen SCSigMatchSilentErrorEnabled
  • Introduce helper SCDetectRegisterBufferLowerMd5Callbacks and generic DetectLowerSetupCallback

#14679 with clean history and no longer draft

bindgen needed SCSigMatchSilentErrorEnabled on the way
Will allow for generic callbacks, that can be used from rust
Introduces helper SCDetectRegisterBufferLowerMd5Callbacks
@codecov
Copy link

codecov bot commented Jan 28, 2026

Codecov Report

❌ Patch coverage is 97.32620% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.13%. Comparing base (7627756) to head (2690b76).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14709      +/-   ##
==========================================
- Coverage   82.13%   82.13%   -0.01%     
==========================================
  Files        1011     1007       -4     
  Lines      263295   263208      -87     
==========================================
- Hits       216258   216175      -83     
+ Misses      47037    47033       -4     
Flag Coverage Δ
fuzzcorpus 60.19% <89.83%> (-0.02%) ⬇️
livemode 18.75% <46.52%> (+0.04%) ⬆️
pcap 44.58% <53.47%> (-0.01%) ⬇️
suricata-verify 65.31% <92.51%> (+<0.01%) ⬆️
unittests 59.36% <52.94%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline = 29313

@victorjulien victorjulien added this to the 9.0 milestone Jan 28, 2026
@victorjulien
Copy link
Member

Ticket would be nice, if only for the changelog.

@catenacyber
Copy link
Contributor Author

@victorjulien
Copy link
Member

Merged in #14712, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants