Skip to content

Conversation

@catenacyber
Copy link
Contributor

Link to ticket: https://redmine.openinfosecfoundation.org/issues/
Should I create a specific one ?

Describe changes:

  • Move ssh detect code to pure rust
  • bindgen SCSigMatchSilentErrorEnabled
  • Introduce helper SCDetectRegisterBufferLowerMd5Callbacks and generic DetectLowerSetupCallback

Follow-up on #14628 and finishes all ssh keywords

bindgen needed SCSigMatchSilentErrorEnabled on the way
Will allow for generic callbacks, that can be used from rust
@suricata-qa
Copy link

WARNING:
ERROR: buid failure for build_asan QA build

field baseline test %
build_asan

Pipeline = 29261

@catenacyber catenacyber marked this pull request as draft January 23, 2026 09:48
@catenacyber
Copy link
Contributor Author

Draft to fix compile warning

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline = 29262

@codecov
Copy link

codecov bot commented Jan 23, 2026

Codecov Report

❌ Patch coverage is 97.32620% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.12%. Comparing base (9df5fd1) to head (10e3722).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14679      +/-   ##
==========================================
+ Coverage   82.11%   82.12%   +0.01%     
==========================================
  Files        1011     1007       -4     
  Lines      262924   262837      -87     
==========================================
- Hits       215896   215855      -41     
+ Misses      47028    46982      -46     
Flag Coverage Δ
fuzzcorpus 60.21% <89.83%> (-0.02%) ⬇️
livemode 18.73% <46.52%> (+0.03%) ⬆️
pcap 44.64% <53.47%> (+0.06%) ⬆️
suricata-verify 65.33% <92.51%> (+0.02%) ⬆️
unittests 59.28% <52.94%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline = 29263

@catenacyber catenacyber mentioned this pull request Jan 28, 2026
@catenacyber
Copy link
Contributor Author

Replaced by #14709

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants