Bindgen more 7762 v8.4.2 #14665
Closed
Bindgen more 7762 v8.4.2 #14665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As will be needed such as AppLayerTxData
and bindgen it to rust. Will make easier the bindgen of RustParser structure which uses a callback which uses AppLayerGetFileState
and bindgen it to rust, and use default trait instead of new Will make easier the bindgen of RustParser structure which uses a callback which uses AppLayerStateData
and bindgen it to rust Will make easier the bindgen of RustParser structure which uses a callback which uses AppLayerGetTxIterTuple
and bindgen it to rust Will make easier the bindgen of RustParser structure which uses a callback which uses StreamSlice
and bindgen it to rust Will make easier the bindgen of RustParser structure which uses a callback which uses AppLayerResult Keep From<> impl in sys crate that defines it
and bindgen it to rust Will make easier the bindgen of RustParser structure which uses a callback which uses AppLayerTxData Move also the free function to C SCAppLayerTxDataCleanup As suricata-sys crate defines AppLayerTxData for rust, It must itself implement the Drop trait, and thus, We need to define a feature surest
and reorder definitions
Ticket: 7662
catenacyber
requested review from
a team,
jasonish,
jufajardini and
victorjulien
as code owners
jasonish
reviewed
Jan 21, 2026
| --disable-header-comment \ | ||
| --default-enum-style rust \ | ||
| --with-derive-default \ | ||
| --with-derive-eq \ |
Member
There was a problem hiding this comment.
These generated Eq, if a struct char pointers, they won't look inside right? Its just looking at the value of the pointer itself?
Contributor
Author
There was a problem hiding this comment.
I assume so yes
Member
Yes, I think so for now. |
Contributor
Author
|
Replaced by #14667 |
the ips drops looks valid. the ether/wrong packet stuff should be cleaned up after 14667 runs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7762
Describe changes:
#14660 without changes to rust/sys/src/lib.rs
@jasonish what do you think ?
I removed the From trait for AppLayerResult and used AppLayerResult directly
And I used a wrapper for AppLayerTxData, makes a bigger diff... is it cleaner in the end ?