Bindgen more 7762 v8.4.1 #14660
Closed
Bindgen more 7762 v8.4.1 #14660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As will be needed such as AppLayerTxData
and bindgen it to rust. Will make easier the bindgen of RustParser structure which uses a callback which uses AppLayerGetFileState
and bindgen it to rust, and use default trait instead of new Will make easier the bindgen of RustParser structure which uses a callback which uses AppLayerStateData
and bindgen it to rust Will make easier the bindgen of RustParser structure which uses a callback which uses AppLayerGetTxIterTuple
and bindgen it to rust Will make easier the bindgen of RustParser structure which uses a callback which uses StreamSlice
catenacyber
requested review from
a team,
jasonish,
jufajardini and
victorjulien
as code owners
catenacyber
force-pushed
the
bindgen-more-7762-v8.4.1
branch
from
8de34c8 to
1eff1dd
Compare
and bindgen it to rust Will make easier the bindgen of RustParser structure which uses a callback which uses AppLayerResult Keep From<> impl in sys crate that defines it
catenacyber
force-pushed
the
bindgen-more-7762-v8.4.1
branch
from
1eff1dd to
f2eca9e
Compare
jasonish
reviewed
Jan 20, 2026
| } | ||
| } | ||
|
|
||
| #[cfg(not(feature = "suritest"))] |
Member
There was a problem hiding this comment.
I think these helpers, and this belong in the main suricata crate now. This -sys crate should be limited to bindings only. Or this new -ffi crate we've discussed. But suricata would be a better place until then.
Contributor
Author
There was a problem hiding this comment.
This is not allowed by rust
error[E0120]: the `Drop` trait may only be implemented for local structs, enums, and unions
--> src/applayer.rs:100:15
|
100 | impl Drop for AppLayerTxData {
| ^^^^^^^^^^^^^^ must be a struct, enum, or union in the current crate
Contributor
Author
There was a problem hiding this comment.
Do you see another way ?
Member
There was a problem hiding this comment.
I think the common idiomatic Rust way is a wrapper like:
pub struct TxData(pub suricata_sys::sys::AppLayerTxData);
You see this pattern a lot.
But I see your point. I think the suritest also shows how details of the Suricata crate are leaking into this crate as well. I assume thats because we need to be linked with the C code for that to compile?
and bindgen it to rust Will make easier the bindgen of RustParser structure which uses a callback which uses AppLayerTxData Move also the free function to C SCAppLayerTxDataCleanup As suricata-sys crate defines AppLayerTxData for rust, It must itself implement the Drop trait, and thus, We need to define a feature surest
and reorder definitions
Ticket: 7662
catenacyber
force-pushed
the
bindgen-more-7762-v8.4.1
branch
from
f2eca9e to
ef21bd1
Compare
Contributor
Author
|
Setting to draft as unclean history for rust fixups |
jasonish
requested changes
Jan 20, 2026
Member
jasonish
left a comment
jasonish
left a comment
There was a problem hiding this comment.
Just the one comment, otherwise looks OK.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #14660 +/- ##
==========================================
- Coverage 82.11% 82.10% -0.02%
==========================================
Files 1011 1012 +1
Lines 262812 262847 +35
==========================================
- Hits 215812 215804 -8
- Misses 47000 47043 +43
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
WARNING:
Pipeline = 29201 |
|
WARNING:
Pipeline = 29210 |
Contributor
Author
|
Replaced by #14665 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7762
Describe changes:
#14627 final round
@jasonish what do you think ?