Quic encryption handling 8116 v2 #14502
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: 8116
as it is not specific to ssh anymore
as it is no longer specific to SSH
To move non-specific quic code to the right place
Ticket: 8116 quic parsing on udp can request bypass. But such a bypass was only handled for TCP protocols in AppLayerParserParse
catenacyber
requested review from
a team,
jasonish,
jufajardini and
victorjulien
as code owners
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #14502 +/- ##
==========================================
- Coverage 82.12% 82.12% -0.01%
==========================================
Files 1013 1014 +1
Lines 262327 262358 +31
==========================================
+ Hits 215439 215456 +17
- Misses 46888 46902 +14
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
WARNING:
Pipeline = 28827 |
| if let Ok(eh) = EncryptionHandling::from_str(val) { | ||
| unsafe { ENCRYPTION_BYPASS_ENABLED = eh }; | ||
| } else { | ||
| SCLogWarning!("Unknown value {} for quic.encryption-handling.", val); |
Member
There was a problem hiding this comment.
can we be strict here? It's a new setting so no reason to allow bad settings?
Contributor
Author
There was a problem hiding this comment.
Going to LogError then
Contributor
Author
|
Next version in #14509 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/8116
Describe changes:
SV_BRANCH=OISF/suricata-verify#2819
#14494 complete no draft