Skip to content

Conversation

@catenacyber
Copy link
Contributor

Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/8116

Describe changes:

  • quic: encryption-handling config parameters

Draft to save work

@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

❌ Patch coverage is 63.33333% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.11%. Comparing base (a53ba4a) to head (61263cb).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14494      +/-   ##
==========================================
- Coverage   82.11%   82.11%   -0.01%     
==========================================
  Files        1013     1013              
  Lines      262322   262344      +22     
==========================================
+ Hits       215408   215414       +6     
- Misses      46914    46930      +16     
Flag Coverage Δ
fuzzcorpus 59.30% <63.33%> (+<0.01%) ⬆️
livemode 18.74% <3.33%> (-0.13%) ⬇️
pcap 44.63% <63.33%> (+<0.01%) ⬆️
suricata-verify 64.98% <63.33%> (-0.01%) ⬇️
unittests 59.26% <30.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline = 28777

static mut ALPROTO_QUIC: AppProto = ALPROTO_UNKNOWN;

static mut ENCRYPTION_BYPASS_ENABLED: SshEncryptionHandling =
SshEncryptionHandling::SSH_HANDLE_ENCRYPTION_TRACK_ONLY;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: rename and move SshEncryptionHandling to something generic in a follow-up commit

SshEncryptionHandling::SSH_HANDLE_ENCRYPTION_BYPASS => {
APP_LAYER_PARSER_NO_INSPECTION
| APP_LAYER_PARSER_NO_REASSEMBLY
| APP_LAYER_PARSER_BYPASS_READY
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO add SV test ?

@catenacyber
Copy link
Contributor Author

No longer a draft in #14502

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants