test: improve server package coverage to 65% #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add unit tests for previously untested components: - marker_test.go: NewRepoMarker, scanColor, Get, paintSVG, paintPNG, scanDir - ammo_test.go: NewRepoAmmo, GetPath - setting_test.go: NewSetting with config files, env vars, defaults Extend integration_test.go with HTTP tests for marker and ammo serving. Coverage improvements: - internal/server: 65% (up from ~60%) - Overall project: 31.6% (up from ~23%)
Merging this branch will increase overall coverage
Coverage by fileChanged unit test files
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
internal/server/New Test Files
marker_test.goNewRepoMarker,scanColor,Get,paintSVG,paintPNG,scanDir,maxammo_test.goNewRepoAmmo,GetPathsetting_test.goNewSetting(config files, env vars, defaults, secret validation)integration_test.goKey Coverage Improvements
marker.go:
NewRepoMarker: 100%scanColor: 100%Get: 93.3%paintPNG: 92%paintSVG: 83.3%scanDir: 93.3%ammo.go:
NewRepoAmmo: 100%GetPath: 100%setting.go:
NewSetting: 94.6%handler.go (key endpoints):
GetMarker: 90.9%GetAmmo: 91.7%Test plan
go test -cover