test: improve coverage for handler, operation, and worker #76
+1,126
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add comprehensive tests for previously untested functions: handler_test.go: - GetOperations, GetCustomize, GetVersion - StoreOperation (with and without conversion trigger) - GetCapture, GetCaptureFile, GetMapTitle, GetStatic - cacheControl, errorHandler, WithConversionTrigger - NewHandler with various options operation_test.go: - GetTypes, SelectAll, UpdateMissionDuration - StoreDefaults, SelectWithFilters worker_test.go: - DefaultConfig, TriggerConversion (success and failure) - NewWorker defaults, FlatBuffers format - Context cancellation handling Coverage improvements: - internal/server: 88.5% (up from 65%) - internal/conversion: 76.3% (up from 64.4%) - Overall project: 36.9% (up from 31.6%)
Merging this branch will increase overall coverage
Coverage by fileChanged unit test files
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Continue test coverage improvements from #75. This PR adds comprehensive tests for previously untested functions in the handler, operation, and worker packages.
Coverage Improvements
internal/serverinternal/conversionNew/Extended Tests
handler_test.go (+500 lines)
TestGetOperations- filter by name, tag, date rangeTestGetCustomize- customization settings endpointTestGetVersion- build version endpointTestStoreOperation- upload with success, wrong secret, invalid durationTestGetCapture/TestGetCaptureFile- data download endpointsTestGetMapTitle/TestGetStatic- static file serving with path traversal protectionTestCacheControl- middleware for cache headersTestErrorHandler- error handling middlewareTestWithConversionTrigger- handler optionTestNewHandler/TestNewHandlerWithOptions- handler initializationoperation_test.go (+120 lines)
TestGetTypes- distinct tag retrievalTestSelectAll- fetch all operationsTestUpdateMissionDuration- duration updateTestStoreDefaults- default values for storage format and conversion statusTestSelectWithFilters- comprehensive filter testingworker_test.go (+170 lines)
TestDefaultConfig- default configuration valuesTestNewWorker_Defaults- worker initialization defaultsTestTriggerConversion- async conversion (success)TestTriggerConversion_Failure- async conversion (failure handling)TestWorker_FlatBuffersFormat- flatbuffers conversionTestWorker_ContextCancellation- graceful shutdownTest plan
go test -cover