Skip to content

Conversation

@ehennestad
Copy link
Collaborator

@ehennestad ehennestad commented Jan 13, 2026

Motivation

Fixes a bug where conversion of NWB inspector metadata to a MATLAB structure fails when metadata is missing (values is represented as a py.NoneType)

How to test the behavior?

N/A

Checklist

  • Have you ensured the PR description clearly describes the problem and solutions?
  • Have you checked to ensure that there aren't other open or previously closed Pull Requests for the same change?
  • If this PR fixes an issue, is the first line of the PR description fix #XX where XX is the issue number?

@ehennestad ehennestad mentioned this pull request Jan 13, 2026
3 tasks
@ehennestad
Copy link
Collaborator Author

Tests are currently failing due to this pending PR:
NeurodataWithoutBorders/nwbinspector#660

@ehennestad ehennestad requested a review from bendichter January 13, 2026 13:57
@bendichter bendichter enabled auto-merge (squash) January 13, 2026 15:17
@bendichter bendichter disabled auto-merge January 13, 2026 15:21
@bendichter bendichter enabled auto-merge (squash) January 13, 2026 15:21
@bendichter bendichter disabled auto-merge January 13, 2026 15:21
@bendichter bendichter merged commit 95bf510 into main Jan 13, 2026
12 of 13 checks passed
@codecov
Copy link

codecov bot commented Jan 13, 2026

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 95.49%. Comparing base (08da374) to head (57eb0c8).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
inspectNwbFile.m 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #781      +/-   ##
==========================================
- Coverage   95.50%   95.49%   -0.01%     
==========================================
  Files         191      191              
  Lines        6922     6931       +9     
==========================================
+ Hits         6611     6619       +8     
- Misses        311      312       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants