Skip to content

Restore variables with noqa: F841 per review feedback#210

Merged
rajeee merged 2 commits intoruff_lintfrom
copilot/sub-pr-209
Feb 3, 2026
Merged

Restore variables with noqa: F841 per review feedback#210
rajeee merged 2 commits intoruff_lintfrom
copilot/sub-pr-209

Conversation

Copy link

Copilot AI commented Feb 3, 2026

Description

Restores three intentionally unused variables that were removed during lint cleanup, adding # noqa: F841 suppressions as requested in code review.

Changes

  • ochre/utils/envelope.py: Restored building_height and building_height_ft variables with noqa comments
  • ochre/utils/equipment.py: Restored ground_temp variable with noqa comment
  • test/test_equipment/test_battery.py: Restored initial_capacity variable with noqa comment

All variables are marked with # noqa: F841 to suppress unused variable warnings while preserving them for potential future use or dynamic access patterns.

Checklist

  • Reference the issue your PR is fixing
  • Assign at least 1 reviewer for your PR
  • Test with run_dwelling.py or other script
  • Update documentation as appropriate
  • Update changelog as appropriate

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Apply ruff lint fixes across codebase Restore variables with noqa: F841 per review feedback Feb 3, 2026
Copilot AI requested a review from rajeee February 3, 2026 18:21
@rajeee rajeee marked this pull request as ready for review February 3, 2026 18:26
@rajeee rajeee merged commit 8eac76a into ruff_lint Feb 3, 2026
10 checks passed
@rajeee rajeee deleted the copilot/sub-pr-209 branch February 3, 2026 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants