Open
Conversation
- Remove unused imports (F401) in scripts and modules - Add __all__ lists to __init__.py files to document public API - Replace star import in test_equipment.py with explicit imports - Fix bare except clause in docs/source/conf.py (E722) - Remove unused local variables (F841) or add noqa for intentional ones - Add noqa comments for acceptable lint exceptions (E402, E741, F403) - All 237 tests pass (1 skipped)
rajeee
commented
Feb 3, 2026
rajeee
commented
Feb 3, 2026
rajeee
commented
Feb 3, 2026
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR builds on top of PR #207 (ruff formatting) to also apply all ruff lint fixes to the codebase.
__all__lists to__init__.pyfiles to document public API and fix re-export warningstest_equipment.pywith explicit imports (fixes F403/F405)exceptclause indocs/source/conf.py(E722 ->except Exception:)Lint Status
Before: 107 errors
After: 0 errors (all checks pass!)
Test Status
All 237 tests pass (1 skipped).
How to run
Notes
heating_des_initandcooling_des_initinochre/utils/equipment.pyare kept with# noqa: F841because they're used dynamically byeval()when loading zone temperature filesfrom .Equipment import *inochre/__init__.pyis kept for API compatibility with# noqa: F403