lion error logs #2073
Draft
lion error logs #2073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fvankrieken
force-pushed
the
fvk-lion-error-logs
branch
4 times, most recently
from
e37218b to
0c57d77
Compare
fvankrieken
force-pushed
the
fvk-lion-error-logs
branch
from
0c57d77 to
c34315a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fvankrieken
force-pushed
the
fvk-lion-error-logs
branch
4 times, most recently
from
317f2ca to
ebf58ca
Compare
fvankrieken
force-pushed
the
fvk-lion-error-logs
branch
4 times, most recently
from
904676a to
dc2162d
Compare
fvankrieken
force-pushed
the
fvk-lion-error-logs
branch
from
dc2162d to
7cbbaa6
Compare
fvankrieken
force-pushed
the
fvk-lion-error-logs
branch
from
4236eb5 to
d50ef3b
Compare
fvankrieken
force-pushed
the
fvk-lion-error-logs
branch
from
d50ef3b to
693140d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2071
leaving commit 4 - thought it was needed as nypd_beat.post is often null, but not for
geo_type = 'hp'records, which we filter to. Intererestingly, this error report is HUGE. But oh wellI haven't checked with Rodrigo, but would like to merge this before worrying about the actual format - I've looked through the reports and the logic seems sound. I'll put together a little report before requesting review