join all nypd beat polygons

Author: fvankrieken

products/cscl/models/intermediate/adjacent_polygons/int__segment_nypdbeat.sql

@@ -12,15 +12,15 @@ SELECT
     co.globalid,
     co.lionkey,
     co.segmentid,
-    left(left_beat.post, 1) AS left_nypd_service_area,
-    left(right_beat.post, 1) AS right_nypd_service_area
+    left_beat.sector AS left_nypd_sector,
+    left_beat.geo_type AS left_beat_geo_type,
+    CASE WHEN left_beat.geo_type = 'HP' THEN left(left_beat.post, 1) END AS left_nypd_service_area,
+    right_beat.sector AS right_nypd_sector,
+    right_beat.geo_type AS right_beat_geo_type,
+    CASE WHEN right_beat.geo_type = 'HP' THEN left(left_beat.post, 1) END AS right_nypd_service_area
 FROM segment_offsets AS co
 -- using a cte around reference can confus the postgres compiler to not use index
 LEFT JOIN {{ source("recipe_sources", "dcp_cscl_nypdbeat") }} AS left_beat
-    ON
-        st_within(co.left_offset_point, left_beat.geom)
-        AND left_beat.geo_type = 'HP'
+    ON st_within(co.left_offset_point, left_beat.geom)
 LEFT JOIN {{ source("recipe_sources", "dcp_cscl_nypdbeat") }} AS right_beat
-    ON
-        st_within(co.right_offset_point, right_beat.geom)
-        AND right_beat.geo_type = 'HP'
+    ON st_within(co.right_offset_point, right_beat.geom)

products/cscl/models/log_files/log__lion_segments_missing_nypd.sql

@@ -1,9 +1,16 @@
+WITH segments AS (
+    SELECT * FROM {{ ref('int__segments') }}
+),
+nypd AS (
+    SELECT * FROM {{ ref('int__segment_nypdbeat') }}
+)
 SELECT
     'segment joined to no nypd beat' AS error,
-    globalid,
-    source_table,
+    segments.globalid,
+    segments.source_table,
     'segmentid' AS record_id_type,
-    segmentid AS record_id,
+    segments.segmentid AS record_id,
     '' AS message
-FROM {{ ref('int__lion') }}
-WHERE left_nypd_service_area IS NULL AND right_nypd_service_area IS NULL
+FROM segments
+INNER JOIN nypd ON segments.lionkey = nypd.lionkey
+WHERE nypd.left_nypd_sector IS NULL AND nypd.right_nypd_sector IS NULL