Skip to content

cicd: enable -Wall -Wextra -Werror for clang #1970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
romintomasetti wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −1
Open

cicd: enable -Wall -Wextra -Werror for clang #1970

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,7 @@ add_library(stdexec_executable_flags INTERFACE)

# Enable warnings
target_compile_options(stdexec_executable_flags INTERFACE
$<$<CXX_COMPILER_ID:Clang>:-pedantic-errors;-Wall;-Wextra;-Werror>
Comment on lines 264 to +265
Copy link
Copy Markdown
Collaborator

@ericniebler ericniebler Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could be wrong but I think by adding these flags to stdexec_executable_flags, you are adding them to every target that links with STDEXEC::stdexec. Consumers of stdexec may not want that.

Perhaps we should add them to the test targets instead. Thoughts?

Copy link
Copy Markdown
Contributor Author

@romintomasetti romintomasetti Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree 👍

$<$<STREQUAL:${stdexec_compiler_frontend},GNU>:-Wall;-Werror=unused-parameter>
$<$<STREQUAL:${stdexec_compiler_frontend},AppleClang>:-Wall>
$<$<STREQUAL:${stdexec_compiler_frontend},MSVC>:/W4>)
Expand Down
2 changes: 1 addition & 1 deletion include/stdexec/__detail/__read_env.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ namespace STDEXEC
}

_Receiver __rcvr_;
__optional<_Ty> __result_;
__optional<_Ty> __result_ = __nullopt;
};

template <class _Receiver, class _Query, class _Ty>
Expand Down
Loading