cicd: enable -Wall -Wextra -Werror for clang#1970
Open
romintomasetti wants to merge 1 commit intoNVIDIA:mainfrom
Open
cicd: enable -Wall -Wextra -Werror for clang#1970romintomasetti wants to merge 1 commit intoNVIDIA:mainfrom
-Wall -Wextra -Werror for clang#1970romintomasetti wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Signed-off-by: romintomasetti <romin.tomasetti@gmail.com>
Collaborator
|
/ok to test d3bea6c |
ericniebler
reviewed
Mar 30, 2026
Comment on lines
264
to
+265
| target_compile_options(stdexec_executable_flags INTERFACE | ||
| $<$<CXX_COMPILER_ID:Clang>:-pedantic-errors;-Wall;-Wextra;-Werror> |
Collaborator
There was a problem hiding this comment.
I could be wrong but I think by adding these flags to stdexec_executable_flags, you are adding them to every target that links with STDEXEC::stdexec. Consumers of stdexec may not want that.
Perhaps we should add them to the test targets instead. Thoughts?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables for
Clangcompiler ID:-Wall -Wextra -Werror-pedantic-errors