fix: use pixi-compatible variable syntax in Windows tasks#1793
fix: use pixi-compatible variable syntax in Windows tasks#1793miyanyan wants to merge 2 commits intoNVIDIA:mainfrom
Conversation
mdboom
left a comment
There was a problem hiding this comment.
Any thoughts about how we could test this so this doesn't happen again?
From what I can tell, the current CI mainly validates the wheel build/test flow ( |
|
Blocking this until there's a test for it seems wrong. Let's just create a follow up to address it. |
rwgk
left a comment
There was a problem hiding this comment.
Blocking this until there's a test for it seems wrong.
I agree.
Let's just create a follow up to address it.
Sounds good to me.
|
/ok to test |
@rwgk, there was an error processing your request: See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/ |
|
/ok to test 0745279 |
|
|
The |
|
/ok to test 3d01d6a |
What
This updates the Windows
pixitask/env definitions in:cuda_pathfinder/pixi.tomlcuda_bindings/pixi.tomlcuda_core/pixi.tomlIt replaces
cmd.exe-style%VAR%references with$VARsyntax in Windows-specificpixitask and environment entries.Why
pixi runexecutes tasks viadeno_task_shell, notcmd.exeor PowerShell.Because of that, values like
%PIXI_PROJECT_ROOT%are passed through literally instead of being expanded on Windows. That causes commands to fail with errors like: