Add smap soil moisture config files to jcb-gdas #2011
Conversation
tsga
requested review from
ClaraDraper-NOAA,
CoryMartin-NOAA,
DavidNew-NOAA and
jiaruidong2017
ClaraDraper-NOAA
left a comment
ClaraDraper-NOAA
left a comment
There was a problem hiding this comment.
Changes look OK to me - I haven't gone through the science in the yamls, as I'm assuming we're focused on engineering for now.
I'm OK for merge, it @CoryMartin-NOAA agrees that these files should be stored in GDASApp. We do eventually hope to assimilate soil moisture obs into the global_worklow, but there will be at least a year of offline development first.
|
Fine with me, a lot of what is already in GDASApp won't be operational in 2026 |
Adds config files for SMAP soil moisture data type. The changes here are intended to be used for JEDI soil DA in the land offline workflow (outside of GW). The corresponding pygfs changes are included in the PR NOAA-PSL/land-offline_workflow#58 Companion GDASApp PR: NOAA-EMC/GDASApp#2011 --------- Co-authored-by: Jiarui Dong <[email protected]>
|
Changes otherwise look good to me, but be advised, observation staging will change soon with NOAA-EMC/global-workflow#4306. |
|
@tsga when you return from travel, could you merge in develop and resolve conflicts? Thanks! |
Adds config files for SMAP soil moisture data type. The changes here are intended to be used for JEDI soil DA in the land offline workflow (outside of GW). The corresponding pygfs changes are included in the PR NOAA-PSL/land-offline_workflow#58 Companion GDASApp PR: #2011 --------- Co-authored-by: Jiarui Dong <[email protected]>
4 participants
Description
This PR adds config files for SMAP soil moisture data type. The changes here are intended to be used for JEDI soil DA in the land offline workflow. The corresponding pygfs changes are included in the PR NOAA-PSL/land-offline_workflow#58
The changes here are only addition of soil config files and do not directly affect any of the tests, but the two related CI tests C96C48_hybatmsnowDA and C96C48_hybatmsoilDA were run and pass on URSA.
Companion PRs
jcb-gdas #218
land-offline workflow #58
Issues
Automated CI tests to run in Global Workflow