Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #385 +/- ##
=======================================
Coverage 96.57% 96.57%
=======================================
Files 6 6
Lines 467 467
=======================================
Hits 451 451
Misses 16 16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to split the core components (the
OffsetArrayandIdOffsetRange-related code) to their own package. The key differentiator would be that this package commits minimal type piracy. The only instance of type piracy would be to define functions likeWhile technically type piracy, a narrower method that accepts a
Tuple{Union{Integer, Base.OneTo}, Vararg{Union{Integer, Base.OneTo}}}exists inBase, so the only types that would dispatch to the new method added in this package are the ones that involve aIdOffsetRange. One key difference here is that we don't define these methods for genericIdentityUnitRanges anymore.Importantly, no user-defined axis types would dispatch to this
similarmethod. This makes it possible for packages to transitively depend onOffsetArraysCorewithout it impacting their code in any way. This would help with issues like #87 and #369.Eventually,
OffsetArraysmay become a wrapper overOffsetArraysCoreand carry out the major type piracies that improve the end-user experience but aren't necessary for package development.Most of the code in this PR is copied over with minimal changes to get it working. The primary changes are to the
similarandreshapemethods to remove the piracy there.