Skip to content

updated trailing in abi.ocp_installer_base_url #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Neeraj8418 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

updated trailing in abi.ocp_installer_base_url #415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f464076
updated trailing in abi.ocp_installer_base_url
Jun 6, 2025
a56eb36
Merge branch 'main' into url_update
veera-damisetti Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion inventories/default/group_vars/all.yaml.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ abi:
flag: False
ansible_workdir: 'ansible_workdir'
ocp_installer_version: '4.18.8'
ocp_installer_base_url: 'https://mirror.openshift.com/pub/openshift-v4'
ocp_installer_base_url: 'https://mirror.openshift.com/pub/openshift-v4/'
architecture: <multi|s390x>
boot_method: <pxe|iso>

Expand Down
6 changes: 3 additions & 3 deletions roles/download_ocp_installer/tasks/main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
---
- name: Download OpenShift Installer (fips=false)
ansible.builtin.get_url:
url: "{{ abi.ocp_installer_base_url }}/{{ abi.architecture | lower }}/clients/ocp/{{ abi.ocp_installer_version }}/{{ 's390x/' if abi.architecture | lower == 'multi' else '' }}{{ ocp_install_tgz }}"
url: "{{ abi.ocp_installer_base_url }}{{ abi.architecture | lower }}/clients/ocp/{{ abi.ocp_installer_version }}/{{ 's390x/' if abi.architecture | lower == 'multi' else '' }}{{ ocp_install_tgz }}"

Check failure on line 4 in roles/download_ocp_installer/tasks/main.yaml

View workflow job for this annotation

GitHub Actions / Ansible_Lint

yaml[line-length] 

Line too long (200 > 160 characters)
dest: "/tmp/{{ ocp_install_tgz }}"
mode: '0640'
validate_certs: false
when: not install_config_vars.fips

- name: Download OpenShift Installer (fips=true)
ansible.builtin.get_url:
url: "{{ abi.ocp_installer_base_url }}/{{ abi.architecture | lower }}/clients/ocp/{{ abi.ocp_installer_version }}/{{ 's390x/' if abi.architecture | lower == 'multi' else '' }}{{ ocp_install_fips_tgz }}-{{ install_config_vars.control.architecture | lower }}.tar.gz"
url: "{{ abi.ocp_installer_base_url }}{{ abi.architecture | lower }}/clients/ocp/{{ abi.ocp_installer_version }}/{{ 's390x/' if abi.architecture | lower == 'multi' else '' }}{{ ocp_install_fips_tgz }}-{{ install_config_vars.control.architecture | lower }}.tar.gz"

Check failure on line 12 in roles/download_ocp_installer/tasks/main.yaml

View workflow job for this annotation

GitHub Actions / Ansible_Lint

yaml[line-length] 

Line too long (267 > 160 characters)
dest: "/tmp/{{ ocp_install_fips_tgz }}-{{ install_config_vars.control.architecture | lower }}.tar.gz"
mode: '0640'
validate_certs: false
Expand All @@ -31,7 +31,7 @@

- name: Download OpenShift Client
ansible.builtin.get_url:
url: "{{ abi.ocp_installer_base_url }}/{{ abi.architecture | lower }}/clients/ocp/{{ abi.ocp_installer_version }}/{{ 's390x/' if abi.architecture | lower == 'multi' else '' }}{{ ocp_client_tgz }}"
url: "{{ abi.ocp_installer_base_url }}{{ abi.architecture | lower }}/clients/ocp/{{ abi.ocp_installer_version }}/{{ 's390x/' if abi.architecture | lower == 'multi' else '' }}{{ ocp_client_tgz }}"

Check failure on line 34 in roles/download_ocp_installer/tasks/main.yaml

View workflow job for this annotation

GitHub Actions / Ansible_Lint

yaml[line-length] 

Line too long (199 > 160 characters)
dest: "/tmp/{{ ocp_client_tgz }}"
mode: '0755'
validate_certs: false
Expand All @@ -42,8 +42,8 @@
dest: /usr/local/bin
remote_src: true

- name: Install NMState package

Check failure on line 45 in roles/download_ocp_installer/tasks/main.yaml

View workflow job for this annotation

GitHub Actions / Ansible_Lint

package-latest 

Package installs should not use latest.
ansible.builtin.yum:

Check failure on line 46 in roles/download_ocp_installer/tasks/main.yaml

View workflow job for this annotation

GitHub Actions / Ansible_Lint

fqcn[action-core] 

Use FQCN for builtin module actions (ansible.builtin.yum).
name: nmstate
state: latest
skip_broken: true
Loading