updated trailing in abi.ocp_installer_base_url#415
Open
Neeraj8418 wants to merge 2 commits intoIBM:mainfrom
Open
updated trailing in abi.ocp_installer_base_url#415Neeraj8418 wants to merge 2 commits intoIBM:mainfrom
Neeraj8418 wants to merge 2 commits intoIBM:mainfrom
Conversation
AmadeusPodvratnik
approved these changes
Jun 18, 2025
Collaborator
AmadeusPodvratnik
left a comment
AmadeusPodvratnik
left a comment
There was a problem hiding this comment.
Hi @Neeraj8418 thx for the PR ... /lgtm
Collaborator
|
@Neeraj8418 Pls fix the DCO check. |
Collaborator
|
@Neeraj8418 thanks |
Collaborator
|
@Neeraj8418 In addition add fix: as a prefix for the heading. Thx. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
abi.ocp_installer_base_url , All the URL values expect a trailing / . But for abi.ocp_installer_base_url variable if we give / at the end it fails with not found error. Alligned it with other similar variables