Skip to content

feat: process Helm chart versions as templates while skaffold render #9938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
magichuihui wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −1
Open

feat: process Helm chart versions as templates while skaffold render #9938

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4555b20
feat: Support templating version of helm chart while render
magichuihui Dec 18, 2025
534050d
fix: return meaningful message when template expansion fails
magichuihui Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion pkg/skaffold/render/renderer/helm/helm.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,10 +178,17 @@ func (h Helm) generateHelmManifest(ctx context.Context, builds []graph.Artifact,
return nil, helm.UserErr(fmt.Sprintf("cannot expand release name %q", release.Name), err)
}

release.ChartPath, err = sUtil.ExpandEnvTemplateOrFail(release.ChartPath, nil)
chartPath, err := sUtil.ExpandEnvTemplateOrFail(release.ChartPath, nil)
if err != nil {
return nil, helm.UserErr(fmt.Sprintf("cannot expand chart path %q", release.ChartPath), err)
}
release.ChartPath = chartPath

version, err := sUtil.ExpandEnvTemplateOrFail(release.Version, nil)
if err != nil {
return nil, helm.UserErr(fmt.Sprintf("cannot expand chart version %q", release.Version), err)
}
release.Version = version

namespace, err := helm.ReleaseNamespace(h.namespace, release)
if err != nil {
Expand Down