feat: process Helm chart versions as templates while skaffold render

[magichuihui]

Fixes: #9937

Description

Skaffold render should support extracting Helm chart versions from environment variables to maintain consistency with skaffold deploy.

Tests

Tested with the below configuration:

apiVersion: skaffold/v4beta12
kind: Config
metadata:
  name: istio-release
deploy:
  helm:
    releases:
    - name: istiod
      namespace: istio-release
      createNamespace: true
      remoteChart: oci://gcr.io/istio-release/charts/istiod
      version: "{{.ISTIO_VERSION}}"
      wait: true

Now we are able to extract the version of Helm chart from environment variables

export ISTIO_VERSION=1.28.0
./skaffold render

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[gemini-code-assist]

Summary of Changes

Hello @magichuihui, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces the capability for skaffold render to process Helm chart versions as templates, enabling dynamic resolution from environment variables. This enhancement ensures that the rendering process maintains behavioral parity with skaffold deploy, providing a more consistent and flexible workflow for managing Helm chart versions across different Skaffold commands.

Highlights

• Helm Chart Version Templating: The skaffold render command now supports templating for Helm chart versions, allowing them to be extracted from environment variables. This ensures consistency with how skaffold deploy handles chart versions.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds support for environment variable templating in Helm chart versions during skaffold render, which is a useful feature for consistency with skaffold deploy. The implementation is straightforward, but I've found a potential issue with error handling that could lead to unhelpful error messages if template expansion fails. My review includes a suggestion to improve this by using a temporary variable to ensure the original value is available for the error message.