Set column limit to 200 in .clang-format #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
From irl convo: Please look and make sure it seems like a good number in different areas Please break into 2 PRs as well, thanks! |
dchansen06
added
Documentation
Signed-off-by: ReginaldWang <[email protected]>
Signed-off-by: ReginaldWang <[email protected]>
Updated .clang-tidy configuration with various checks and options. Signed-off-by: ReginaldWang <[email protected]>
Contributor
|
I rebased to catch up this with PR #169 |
Signed-off-by: ReginaldWang <[email protected]>
Signed-off-by: ReginaldWang <[email protected]>
ReginaldWang
changed the title
Signed-off-by: ReginaldWang <[email protected]>
dchansen06
previously approved these changes
Jan 9, 2026
Contributor
dchansen06
left a comment
dchansen06
left a comment
There was a problem hiding this comment.
I reviewed (way too many) and I am quite happy. There are a few areas where preprocessor defines could look better with multiline comment, but overall I am very happy with the fix. Please wait for me to merge this in to give warning time for others, thanks!
This was referenced Jan 9, 2026
Signed-off-by: Daniel Hansen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Column Limit Formatting
Problem and Scope
For issue #161, the character limit per line is too short. The code appears disjointed and ugly.
Description
Increase column limit to 200 should be sufficient. Lines with a long character count are now all in one line (for the files I checked) instead of broken up.
Gotchas and Limitations
I can increase the number if I find lines that are still disjointed.
Testing
Testing Details
Inspecting a large collection of important files and verifying they look good, and that the format actions still runs
Larger Impact
Code readability
Additional Context and Ticket
Resolves #161