Correct CMAKE_BUILD_TYPE usage #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuChe777
added
Documentation
dchansen06
previously approved these changes
Dec 5, 2025
Contributor
dchansen06
left a comment
dchansen06
left a comment
There was a problem hiding this comment.
I like the future proofing with TARGET_TYPE! Lgtm thx
Contributor
|
Investigating why actions did not run... |
dchansen06
force-pushed
the
correct-cmake-build-type
branch
2 times, most recently
from
50330e6 to
062faa0
Compare
Contributor
|
Docker is currently having issues so 19957686754 fails, but that is 100% unrelated so I will override this anyway, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct CMAKE_BUILD_TYPE usage
Problem and Scope
CMAKE_BUILD_TYPE has a standard list of appropriate values that does not include "Test," which the entire monorepo relies on currently.
Description
Will introduce a new way to check preset state that does not obfuscate the use of CMAKE_BUILD_TYPE.
Gotchas and Limitations
All future projects should be mindful of this change, as this changes the way projects should introduce their tests.
Testing
Testing Details
Tested that compilations work for all preset.
Larger Impact
All future projects should be mindful of this change, as this changes the way projects should introduce their tests.
Additional Context and Ticket
#85