feat: add Latesttag location resolver for init-time tag discovery by redpanda-f · Pull Request #83 · FilOzone/foc-devnet

redpanda-f · 2026-03-09T09:21:53Z

Part of #72

Copilot

Pull request overview

Adds a new Location::LatestTag config variant intended to be resolved at init time into a concrete GitTag, enabling “latest release tag on branch” discovery while keeping config.toml pinned/reproducible.

Changes:

Introduces latesttag:<branch> parsing in Location and documents it in CLI help + README.
Adds an init-time resolver (latest_resolver) that probes the remote with git to convert LatestTag → GitTag.
Updates status/version/init/build codepaths to recognize LatestTag (generally treating it as an error/unresolved outside init-time resolution).

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
src/main_app/version.rs	Displays `LatestTag` as “unresolved” in version/location output.
src/config.rs	Adds `Location::LatestTag` and parsing support for `latesttag:<branch>`.
src/commands/status/git/repo_paths.rs	Treats `LatestTag` like other git-based sources for repo path resolution.
src/commands/status/git/formatters.rs	Formats `LatestTag` as unresolved + marks it not ready.
src/commands/init/repositories.rs	Errors if `LatestTag` reaches repository download step.
src/commands/init/mod.rs	Registers the new `latest_resolver` module.
src/commands/init/latest_resolver.rs	Implements git-based discovery to resolve newest merged tag on a branch.
src/commands/init/config.rs	Resolves `LatestTag` to `GitTag` during config generation.
src/commands/build/repository.rs	Errors if `LatestTag` reaches build-time repo preparation.
src/cli.rs	Updates CLI docs to include `latesttag:<branch>` for init/config.
README_ADVANCED.md	Documents `latesttag:<branch>` behavior and intent.

src/commands/status/git/formatters.rs

Copilot · 2026-03-09T09:29:40Z

src/commands/init/config.rs

+    // Resolve any dynamic variants (LatestTag) by querying the remote.
+    // The resolved concrete tag is stored in config.toml for reproducibility.
+    config.lotus = resolve_location(config.lotus)?;
+    config.curio = resolve_location(config.curio)?;
+    config.filecoin_services = resolve_location(config.filecoin_services)?;


LatestTag resolution only runs when generating a new config. If a config already exists (or is updated via foc-devnet config ...), LatestTag can remain in config.toml, but later init/build paths error out with “should have been resolved at init time”. Consider resolving LatestTag when loading config (or when applying overrides / updating config) and writing back the resolved GitTag for reproducibility.

src/commands/init/config.rs

src/commands/init/latest_resolver.rs

src/commands/init/repositories.rs

src/config.rs

src/commands/init/latest_resolver.rs

src/commands/build/repository.rs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot · 2026-03-09T12:00:17Z

@redpanda-f I've opened a new pull request, #85, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…le-level constant (#85) * Initial plan * refactor: decompose fetch_latest_tag into focused helpers with module-level constant Co-authored-by: redpanda-f <181817029+redpanda-f@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: redpanda-f <181817029+redpanda-f@users.noreply.github.com>

src/commands/init/latest_resolver.rs

src/commands/build/repository.rs

src/commands/init/latest_resolver.rs

src/config.rs

README_ADVANCED.md

src/config.rs

Co-authored-by: Rod Vagg <rod@vagg.org>

Copilot · 2026-03-11T13:10:09Z

@redpanda-f I've opened a new pull request, #91, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2026-03-11T13:10:37Z

@redpanda-f I've opened a new pull request, #92, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2026-03-11T13:10:58Z

@redpanda-f I've opened a new pull request, #93, to work on those changes. Once the pull request is ready, I'll request review from you.

* Initial plan * rename _type to loc_type in resolve_with_default Co-authored-by: redpanda-f <181817029+redpanda-f@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: redpanda-f <181817029+redpanda-f@users.noreply.github.com>

…nd (#93) * Initial plan * Simplify latesttag handling with early return, drop lifetimes dance Co-authored-by: redpanda-f <181817029+redpanda-f@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: redpanda-f <181817029+redpanda-f@users.noreply.github.com>

* Initial plan * Replace invalid v/* glob pattern with v* in docs and code Co-authored-by: redpanda-f <181817029+redpanda-f@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: redpanda-f <181817029+redpanda-f@users.noreply.github.com>

feat: add LatestTag location resolver for init-time tag discovery

a66aa34

redpanda-f requested a review from rvagg March 9, 2026 09:21

redpanda-f self-assigned this Mar 9, 2026

Copilot AI review requested due to automatic review settings March 9, 2026 09:21

FilOzzy added this to FOC Mar 9, 2026

github-project-automation bot moved this to 📌 Triage in FOC Mar 9, 2026

Copilot started reviewing on behalf of redpanda-f March 9, 2026 09:22 View session

Copilot AI reviewed Mar 9, 2026

View reviewed changes

redpanda-f and others added 2 commits March 9, 2026 11:56

makehappy: fmt

a3613aa

Update src/commands/init/latest_resolver.rs

57af83a

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI mentioned this pull request Mar 9, 2026

refactor: decompose fetch_latest_tag into focused helpers with module-level constant #85

Merged

redpanda-f and others added 4 commits March 9, 2026 17:30

Update src/commands/init/repositories.rs

28211b8

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/config.rs

6049096

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/config.rs

5894a65

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

redpanda-f mentioned this pull request Mar 9, 2026

[TRACIER - DO NO MERGE] feat: scenario tests for nightly CI runs #72

Closed

4 tasks

fix: remove usage of deprecated methods

93c5332

rvagg reviewed Mar 10, 2026

View reviewed changes

src/commands/init/latest_resolver.rs Outdated Show resolved Hide resolved

rvagg reviewed Mar 10, 2026

View reviewed changes

src/commands/build/repository.rs Outdated Show resolved Hide resolved

rvagg reviewed Mar 10, 2026

View reviewed changes

src/commands/init/latest_resolver.rs Outdated Show resolved Hide resolved

rvagg reviewed Mar 10, 2026

View reviewed changes

src/commands/init/latest_resolver.rs Outdated Show resolved Hide resolved

redpanda-f added 3 commits March 10, 2026 04:59

fix: new resolver

7e562ab

fixup: latesttag

83b2bd6

fixup: clippy issues

880c442

BigLep moved this from 📌 Triage to 🔎 Awaiting review in FOC Mar 10, 2026

redpanda-f mentioned this pull request Mar 10, 2026

feat: CI overhaul for nightlies and PRs #90

Merged

BigLep requested a review from rvagg March 10, 2026 21:23

rvagg reviewed Mar 11, 2026

View reviewed changes

src/config.rs Outdated Show resolved Hide resolved

rvagg reviewed Mar 11, 2026

View reviewed changes

src/config.rs Outdated Show resolved Hide resolved

rvagg reviewed Mar 11, 2026

View reviewed changes

README_ADVANCED.md Outdated Show resolved Hide resolved

rvagg reviewed Mar 11, 2026

View reviewed changes

src/config.rs Outdated Show resolved Hide resolved

Update src/config.rs

e48ac15

Co-authored-by: Rod Vagg <rod@vagg.org>

Copilot AI mentioned this pull request Mar 11, 2026

Rename _type to loc_type in resolve_with_default #91

Merged

This was referenced Mar 11, 2026

Fix invalid v/* glob example — replace with v* throughout #92

Merged

Simplify latesttag branch with early return, drop lifetime workaround #93

Merged

Copilot AI and others added 3 commits March 11, 2026 18:45

rvagg approved these changes Mar 12, 2026

View reviewed changes

github-project-automation bot moved this from 🔎 Awaiting review to ✔️ Approved by reviewer in FOC Mar 12, 2026

redpanda-f merged commit 3164e17 into main Mar 13, 2026
5 of 6 checks passed

github-project-automation bot moved this from ✔️ Approved by reviewer to 🎉 Done in FOC Mar 13, 2026

redpanda-f deleted the feat/redpanda/latesttag-resolver branch March 13, 2026 02:55

Conversation

redpanda-f commented Mar 9, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Mar 9, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Mar 11, 2026

Uh oh!

Copilot AI commented Mar 11, 2026

Uh oh!

Copilot AI commented Mar 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants