feat: CI overhaul for nightlies and PRs#90
Merged
redpanda-f merged 6 commits intomainfrom Mar 13, 2026
Merged
Conversation
4 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the repository’s GitHub Actions CI into a reusable workflow that can be invoked by separate entrypoint workflows for pull requests and nightly runs, with optional scenario-test reporting to GitHub issues.
Changes:
- Convert CI “meat” into a reusable
workflow_callworkflow with inputs to control dependency versions and reporting. - Add a PR-triggered workflow that runs linting and then invokes the reusable CI run with default settings.
- Add a nightly workflow (schedule + manual dispatch) that runs a stability/frontier matrix and enables issue reporting.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
.github/workflows/ci_run.yml |
Introduces reusable CI run with inputs, caching tweaks, scenario execution, artifact upload, and optional issue reporting. |
.github/workflows/ci_pull_request.yml |
Adds PR workflow: lint + invoke reusable CI run (default config, reporting off). |
.github/workflows/ci_nightly.yml |
Adds nightly matrix workflow calling reusable CI run with different init_flags and reporting settings. |
Comments suppressed due to low confidence (5)
.github/workflows/ci_run.yml:367
- Node/pnpm versions are set to floating values (
node-version: lts/*andpnpm version: latest). This makes CI non-reproducible and can break unexpectedly when upstream releases change; pin these to known-good major/minor versions (or at least a major) to keep runs stable.
.github/workflows/ci_run.yml:52 - The reusable workflow grants
issues: writefor the entire job even whenenable_reportingis false (e.g., PR runs). Consider reducing token scope by moving issue-writing steps into a separate job/workflow that is only invoked when reporting is enabled, or by setting more restrictive permissions in callers when possible.
.github/workflows/ci_run.yml:403 - The "Get CI job ID" step runs under
if: always()but will still fail the job if the GitHub API call orjqprocessing errors (it usescurl -sSfL). To avoid flakiness/masking the real failure cause, make this step non-fatal (e.g.,continue-on-error: trueor handle curl/jq failures and just emit a warning).
.github/workflows/ci_run.yml:400 - In the "Get CI job ID" step, the value written to
$GITHUB_ENVuses$JOB_ID, but that variable is never set. This likely exports an emptyGITHUB_CI_JOB_ID, defeating the purpose of resolving the numeric job ID for scenario reports.
.github/workflows/ci_run.yml:408 - This workflow calls
./scripts/setup-scenarios-prerequisites.sh, but that file is not present in this PR branch (and there is noscripts/directory). Unless this PR is rebased to include the dependency that adds the scenario prerequisites script, the CI run will fail before scenarios execute.
fbea2af to
1362a52
Compare
22 tasks
rjan90
reviewed
Mar 11, 2026
rjan90
reviewed
Mar 11, 2026
rvagg
reviewed
Mar 11, 2026
rvagg
reviewed
Mar 11, 2026
rvagg
reviewed
Mar 11, 2026
Co-authored-by: Rod Vagg <rod@vagg.org>
Co-authored-by: Rod Vagg <rod@vagg.org>
rvagg
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #72. Readies up CI for nightlies run and reporting to labelled issues in foc-devnet.
Depends on: