Skip to content

feat: CI overhaul for nightlies and PRs#90

Merged
redpanda-f merged 6 commits intomainfrom
feat/redpanda/ci-workflow-overhaul
Mar 13, 2026
Merged

feat: CI overhaul for nightlies and PRs#90
redpanda-f merged 6 commits intomainfrom
feat/redpanda/ci-workflow-overhaul

Conversation

@redpanda-f
Copy link
Contributor

@redpanda-f redpanda-f commented Mar 10, 2026

Part of #72. Readies up CI for nightlies run and reporting to labelled issues in foc-devnet.

Depends on:

@redpanda-f redpanda-f requested a review from rvagg March 10, 2026 07:45
@redpanda-f redpanda-f self-assigned this Mar 10, 2026
Copilot AI review requested due to automatic review settings March 10, 2026 07:45
@FilOzzy FilOzzy added this to FOC Mar 10, 2026
@github-project-automation github-project-automation bot moved this to 📌 Triage in FOC Mar 10, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the repository’s GitHub Actions CI into a reusable workflow that can be invoked by separate entrypoint workflows for pull requests and nightly runs, with optional scenario-test reporting to GitHub issues.

Changes:

  • Convert CI “meat” into a reusable workflow_call workflow with inputs to control dependency versions and reporting.
  • Add a PR-triggered workflow that runs linting and then invokes the reusable CI run with default settings.
  • Add a nightly workflow (schedule + manual dispatch) that runs a stability/frontier matrix and enables issue reporting.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
.github/workflows/ci_run.yml Introduces reusable CI run with inputs, caching tweaks, scenario execution, artifact upload, and optional issue reporting.
.github/workflows/ci_pull_request.yml Adds PR workflow: lint + invoke reusable CI run (default config, reporting off).
.github/workflows/ci_nightly.yml Adds nightly matrix workflow calling reusable CI run with different init_flags and reporting settings.
Comments suppressed due to low confidence (5)

.github/workflows/ci_run.yml:367

  • Node/pnpm versions are set to floating values (node-version: lts/* and pnpm version: latest). This makes CI non-reproducible and can break unexpectedly when upstream releases change; pin these to known-good major/minor versions (or at least a major) to keep runs stable.
    .github/workflows/ci_run.yml:52
  • The reusable workflow grants issues: write for the entire job even when enable_reporting is false (e.g., PR runs). Consider reducing token scope by moving issue-writing steps into a separate job/workflow that is only invoked when reporting is enabled, or by setting more restrictive permissions in callers when possible.
    .github/workflows/ci_run.yml:403
  • The "Get CI job ID" step runs under if: always() but will still fail the job if the GitHub API call or jq processing errors (it uses curl -sSfL). To avoid flakiness/masking the real failure cause, make this step non-fatal (e.g., continue-on-error: true or handle curl/jq failures and just emit a warning).
    .github/workflows/ci_run.yml:400
  • In the "Get CI job ID" step, the value written to $GITHUB_ENV uses $JOB_ID, but that variable is never set. This likely exports an empty GITHUB_CI_JOB_ID, defeating the purpose of resolving the numeric job ID for scenario reports.
    .github/workflows/ci_run.yml:408
  • This workflow calls ./scripts/setup-scenarios-prerequisites.sh, but that file is not present in this PR branch (and there is no scripts/ directory). Unless this PR is rebased to include the dependency that adds the scenario prerequisites script, the CI run will fail before scenarios execute.

@redpanda-f redpanda-f marked this pull request as draft March 10, 2026 09:04
@redpanda-f redpanda-f changed the title feat: overhaul CI into reusable workflow with nightly and PR triggers (depends on scenario tests) feat: CI overhaul for nightlies and PRs Mar 10, 2026
@redpanda-f redpanda-f force-pushed the feat/redpanda/ci-workflow-overhaul branch from fbea2af to 1362a52 Compare March 10, 2026 12:18
@redpanda-f redpanda-f marked this pull request as ready for review March 10, 2026 12:20
@BigLep BigLep moved this from 📌 Triage to 🔎 Awaiting review in FOC Mar 10, 2026
@github-project-automation github-project-automation bot moved this from 🔎 Awaiting review to ✔️ Approved by reviewer in FOC Mar 12, 2026
@BigLep BigLep linked an issue Mar 12, 2026 that may be closed by this pull request
@redpanda-f redpanda-f merged commit 6f08b53 into main Mar 13, 2026
3 checks passed
@github-project-automation github-project-automation bot moved this from ✔️ Approved by reviewer to 🎉 Done in FOC Mar 13, 2026
@redpanda-f redpanda-f deleted the feat/redpanda/ci-workflow-overhaul branch March 13, 2026 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

CI/Nightly End-to-End Validation of FOC as a whole

4 participants