-
Notifications
You must be signed in to change notification settings - Fork 3.5k
feat: Add Vacation delegate view for the delegate #78432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
samranahm
wants to merge
24
commits into
Expensify:main
Choose a base branch
from
samranahm:78037/vacation-delegate-in-status-page
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
570dcf6
Add vacation delegate handling to StatusPage with active delegations …
samranahm 888da9b
Add delegatorFor field to VacationDelegate type
samranahm 669b77d
add cannotSetVacationDelegate message in all locals
samranahm d5a8f71
fix: set interactive false for delegator MenuItem component in Status…
samranahm 1dfe78c
add error page for users with active vacation delegations
samranahm 56bd5bc
refactor: extract delegator list rendering into a separate function i…
samranahm 1904c04
Merge remote-tracking branch 'upstream/main' into 78037/vacation-dele…
samranahm 95095aa
Merge remote-tracking branch 'upstream/main' into 78037/vacation-dele…
samranahm 10a4954
refactor: simplify hasActiveDelegations condition in StatusPage
samranahm f42223f
remove redundant check from renderDelegatorList
samranahm ccb3bfd
Merge remote-tracking branch 'upstream/main' into 78037/vacation-dele…
samranahm c995a24
prevent scroll to bottom in status page
samranahm 6f25a87
Merge remote-tracking branch 'upstream/main' into 78037/vacation-dele…
samranahm 1d6431a
feat: add cannot set vacation delegate view in VacationDelegatePage
samranahm 9ab07fb
feat: add fixed footer with save button to StatusPage
samranahm abaf6c5
Merge branch 'Expensify:main' into 78037/vacation-delegate-in-status-…
samranahm c744977
feat: add usePersonalDetailsByLogin hook
samranahm d736c0f
fix: keyboard reopen on modal hide in VacationDelegatePage
samranahm 1196473
Merge remote-tracking branch 'upstream/main' into 78037/vacation-dele…
samranahm 68f91df
Merge remote-tracking branch 'upstream/main' into 78037/vacation-dele…
samranahm e18be67
Merge branch 'Expensify:main' into 78037/vacation-delegate-in-status-…
samranahm 95aa9af
Merge remote-tracking branch 'upstream/main' into 78037/vacation-dele…
samranahm 87e125a
replace Text import to use custom Text component
samranahm f5b53f4
Add form state handling and button loading indicator
samranahm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| import {useMemo} from 'react'; | ||
| import ONYXKEYS from '@src/ONYXKEYS'; | ||
| import type {PersonalDetails} from '@src/types/onyx'; | ||
| import useOnyx from './useOnyx'; | ||
|
|
||
| /** | ||
| * Hook that returns personal details indexed by login email. | ||
| * Enables case-insensitive lookups. | ||
| */ | ||
| function usePersonalDetailsByLogin(): Record<string, PersonalDetails> { | ||
| const [personalDetails] = useOnyx(ONYXKEYS.PERSONAL_DETAILS_LIST, {canBeMissing: true}); | ||
|
|
||
| return useMemo(() => { | ||
| if (!personalDetails) { | ||
| return {}; | ||
| } | ||
|
|
||
| return Object.values(personalDetails).reduce((acc: Record<string, PersonalDetails>, detail) => { | ||
| if (detail?.login) { | ||
| acc[detail.login.toLowerCase()] = detail; | ||
| } | ||
| return acc; | ||
| }, {}); | ||
| }, [personalDetails]); | ||
| } | ||
|
|
||
| export default usePersonalDetailsByLogin; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.