feat: Add Vacation delegate view for the delegate by samranahm · Pull Request #78432 · Expensify/App

samranahm · 2025-12-24T19:10:44Z

Explanation of Change

We're adding the Vacation Delegate view for delegates on the Status page.

Fixed Issues

$ #78037
PROPOSAL: #78037 (comment)

Tests

Precondition: User A is not a delegate for anyone.

User A opens the Status page and select "Vacation delegate" menu item.
User A sets User B as their vacation delegate.
User B opens the Status page
Verify the following message is displayed along with users list

You can't set a vacation delegate because you're currently the delegate for the following members:

Verify User A is listed.
Verify the “Vacation Delegate” menu item is not shown for User B.
Another user sets User B as their vacation delegate.
Verify all users who delegated to User B are listed.
Open this url https://dev.new.expensify.com:8082/settings/profile/status/vacation-delegate and verify:

User B get the "You can't set a vacation delegate..." message along with users list
User A get the normal flow to update the Vacation delegate
Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as test
// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Will add the Screenshots/Videos of remaining platforms once the BE update deployed.

Screenshots/Videos

Android: Native

Android.Native.1.mov

Android: mWeb Chrome

Android.mWeb.Chrome.1.mov

iOS: Native

IOS.Native.1.mov

iOS: mWeb Safari

IOS.mWeb.Safari.1.mov

MacOS: Chrome / Safari

macOS.chrome.mov

…check

melvin-bot · 2025-12-24T19:10:51Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

Copilot

Pull request overview

This PR adds a vacation delegate view for users who are currently acting as delegates for other members. When a user is set as a vacation delegate by others, they cannot set their own vacation delegate, and instead see a list of all members who have delegated to them.

Key Changes:

Added delegatorFor field to VacationDelegate type to track users delegating to the current user
Implemented conditional rendering in StatusPage to show delegator list when user has active delegations
Added translations for the "cannot set vacation delegate" message across all supported languages

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/types/onyx/VacationDelegate.ts	Added `delegatorFor` field to track array of delegator emails
src/pages/settings/Profile/CustomStatus/StatusPage.tsx	Added conditional UI to display delegators list or vacation delegate settings based on delegation status
src/languages/en.ts	Added English translation for "cannot set vacation delegate" message
src/languages/es.ts	Added Spanish translation
src/languages/de.ts	Added German translation
src/languages/fr.ts	Added French translation
src/languages/it.ts	Added Italian translation
src/languages/ja.ts	Added Japanese translation
src/languages/nl.ts	Added Dutch translation
src/languages/pl.ts	Added Polish translation
src/languages/pt-BR.ts	Added Portuguese (Brazil) translation
src/languages/zh-hans.ts	Added Chinese (Simplified) translation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/pages/settings/Profile/CustomStatus/StatusPage.tsx

codecov · 2025-12-24T19:19:41Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/hooks/usePersonalDetailsByLogin.ts	`0.00% <0.00%> (ø)`
...ings/Profile/CustomStatus/VacationDelegatePage.tsx	`0.00% <0.00%> (ø)`
...pages/settings/Profile/CustomStatus/StatusPage.tsx	`0.00% <0.00%> (ø)`
... and 1116 files with indirect coverage changes

…Page

huult · 2025-12-26T04:41:59Z

Weird, Melvin bot added many reviewers

huult · 2025-12-26T04:43:45Z

Link to Slack message:

@samranahm You missed the link to the Slack message in the checklist

huult · 2025-12-26T04:45:12Z

@samranahm Please fill in the QA steps as well

src/pages/settings/Profile/CustomStatus/StatusPage.tsx

…n StatusPage

samranahm · 2025-12-26T09:16:35Z

@huult Please take a look.

huult · 2025-12-29T09:34:34Z

@Beamanator Will this API be ready this week?

samranahm · 2026-01-23T23:00:46Z

@huult All three errors have been fixed. Please take a look and let me know what you think.

Kapture.2026-01-26.at.13.38.54.mp4

samranahm · 2026-01-26T08:43:17Z

@huult Friendly bump.

huult · 2026-01-26T08:45:18Z

@samranahm I’ll check it today and update you.

samranahm · 2026-01-26T08:46:41Z

Got it, Thank you 🙌

huult · 2026-01-27T07:01:50Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-01-27.at.13.47.31.mp4

Android: mWeb Chrome

Screen.Recording.2026-01-27.at.13.49.24.mp4

iOS: HybridApp

Screen.Recording.2026-01-27.at.13.53.30.mp4

iOS: mWeb Safari

Screen.Recording.2026-01-27.at.13.54.47.mp4

MacOS: Chrome / Safari

Screen.Recording.2026-01-27.at.13.42.30.mp4

huult

LGTM

samranahm · 2026-01-27T19:30:02Z

@Beamanator All yours.

src/pages/settings/Profile/CustomStatus/StatusPage.tsx

…gate-in-status-page

samranahm · 2026-02-02T15:00:21Z

Resolved merge conflicts.

huult · 2026-02-03T02:22:54Z

@samranahm please resolve the conflict!

…gate-in-status-page

samranahm · 2026-02-03T17:22:30Z

Resolved merge conflicts.

samranahm · 2026-02-04T15:57:24Z

@Beamanator Friendly bump.

Beamanator · 2026-02-05T19:34:57Z

Back to this today, sorry for the delay!!

samranahm · 2026-02-05T19:38:44Z

Let me merge main to fix failing check.

…page

Beamanator · 2026-02-05T19:57:22Z

darnnn still broken - rerunning....

samranahm · 2026-02-05T19:59:37Z

Nothing in our PR seems to be causing this, not sure why it’s happening.

samranahm · 2026-02-05T20:17:58Z

Ah, it still doesn’t fix the issue.

Beamanator · 2026-02-05T20:47:25Z

discussing a bit here - https://expensify.slack.com/archives/C01GTK53T8Q/p1770324127028209

Beamanator · 2026-02-05T20:52:50Z

@samranahm can you please pull main once more? I think a few eslint errors may have been fixed very very recently

Krishna2323 · 2026-02-05T21:18:28Z

src/pages/settings/Profile/CustomStatus/VacationDelegatePage.tsx

@@ -1,14 +1,16 @@
 import React, {useCallback, useEffect, useMemo, useState} from 'react';
-import {View} from 'react-native';
+import {Text, View} from 'react-native';


@samranahm this is causing the failure. 'Text' import from 'react-native' is restricted.

Thanks a lot @Krishna2323. That was indeed causing the failure, and it’s fixed now.

…gate-in-status-page

samranahm · 2026-02-06T08:10:01Z

All tests are passing 🎆. @Beamanator, please have a look.

Beamanator · 2026-02-06T18:07:38Z

src/pages/settings/Profile/CustomStatus/StatusPage.tsx

+                    success
+                    large
+                    style={styles.w100}
+                    text={translate('statusPage.save')}
+                    onPress={() => formRef.current?.submit()}
+                    pressOnEnter
+                    enterKeyEventListenerPriority={1}
+                />
+            </FixedFooter>
        </ScreenWrapper>
    );
 }


@samranahm Two questions about moving the submit button out of FormProvider and into a standalone FixedFooter:

Loading/disabled state: FormProvider's built-in submit button automatically shows a spinner and disables itself during form submission. This standalone Button doesn't have that behavior, so there's a potential double-submission risk if the user taps quickly. Was this considered, or is there something else preventing it?

Button visibility when hasActiveDelegations is true: The FixedFooter is rendered unconditionally outside the form, so when a delegate sees the "you can't set a vacation delegate" message, they still see a "Save" button at the bottom. I assume this is intentional since the status/emoji form fields above still need saving — just want to confirm the UX is correct in that state.

@Beamanator Thank you for the review and for catching important points!

Loading/disabled state: You're absolutely right about the double-submission risk (Although we navigate back immediately on first submit, but we should handle any edge case). Let me implemented the same loading state logic that FormProvider's built-in button uses.

Button visibility when hasActiveDelegations is true: Yes, this is intentional! When a user is acting as a delegate, they can't set a vacation delegate themselves, but they can still update their status and clear it after settings.

Makes sense!! Thanks!

samranahm added 3 commits December 24, 2025 23:26

Add vacation delegate handling to StatusPage with active delegations …

570dcf6

…check

Add delegatorFor field to VacationDelegate type

888da9b

add cannotSetVacationDelegate message in all locals

669b77d

Copilot AI review requested due to automatic review settings December 24, 2025 19:10

samranahm requested review from a team as code owners December 24, 2025 19:10

melvin-bot bot requested review from Beamanator and huult December 24, 2025 19:10

melvin-bot bot assigned samranahm Dec 24, 2025

melvin-bot bot requested review from JmillsExpensify, flaviadefaria, heyjennahay, joekaufmanexpensify and trjExpensify December 24, 2025 19:10

Copilot started reviewing on behalf of samranahm December 24, 2025 19:11 View session

samranahm mentioned this pull request Dec 24, 2025

[$250] Add "Vacation Delegate" view for the delegate #78037

Open

Copilot AI reviewed Dec 24, 2025

View reviewed changes

src/pages/settings/Profile/CustomStatus/StatusPage.tsx Outdated Show resolved Hide resolved

samranahm added 2 commits December 25, 2025 00:33

fix: set interactive false for delegator MenuItem component in Status…

d5a8f71

…Page

add error page for users with active vacation delegations

1dfe78c

huult reviewed Dec 26, 2025

View reviewed changes

src/pages/settings/Profile/CustomStatus/StatusPage.tsx Outdated Show resolved Hide resolved

refactor: extract delegator list rendering into a separate function i…

56bd5bc

…n StatusPage

Beamanator removed request for heyjennahay and joekaufmanexpensify December 29, 2025 16:02

samranahm added 2 commits January 24, 2026 03:53

feat: add usePersonalDetailsByLogin hook

c744977

fix: keyboard reopen on modal hide in VacationDelegatePage

d736c0f

huult approved these changes Jan 27, 2026

View reviewed changes

Beamanator reviewed Jan 27, 2026

View reviewed changes

src/pages/settings/Profile/CustomStatus/StatusPage.tsx Show resolved Hide resolved

Merge remote-tracking branch 'upstream/main' into 78037/vacation-dele…

1196473

…gate-in-status-page

Merge remote-tracking branch 'upstream/main' into 78037/vacation-dele…

68f91df

…gate-in-status-page

Merge branch 'Expensify:main' into 78037/vacation-delegate-in-status-…

e18be67

…page

Krishna2323 reviewed Feb 5, 2026

View reviewed changes

samranahm added 2 commits February 6, 2026 12:37

Merge remote-tracking branch 'upstream/main' into 78037/vacation-dele…

95aa9af

…gate-in-status-page

replace Text import to use custom Text component

87e125a

Beamanator reviewed Feb 6, 2026

View reviewed changes

Add form state handling and button loading indicator

f5b53f4

Conversation

samranahm commented Dec 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Dec 24, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

codecov bot commented Dec 24, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

huult commented Dec 26, 2025

Uh oh!

huult commented Dec 26, 2025

Uh oh!

huult commented Dec 26, 2025

Uh oh!

Uh oh!

samranahm commented Dec 26, 2025

Uh oh!

huult commented Dec 29, 2025

Uh oh!

samranahm commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

samranahm commented Jan 26, 2026

Uh oh!

huult commented Jan 26, 2026

Uh oh!

samranahm commented Jan 26, 2026

Uh oh!

huult commented Jan 27, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

huult left a comment

Choose a reason for hiding this comment

Uh oh!

samranahm commented Jan 27, 2026

Uh oh!

Uh oh!

samranahm commented Feb 2, 2026

Uh oh!

huult commented Feb 3, 2026

Uh oh!

samranahm commented Feb 3, 2026

Uh oh!

samranahm commented Feb 4, 2026

Uh oh!

Beamanator commented Feb 5, 2026

Uh oh!

samranahm commented Feb 5, 2026

Uh oh!

Beamanator commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

samranahm commented Feb 5, 2026

Uh oh!

samranahm commented Feb 5, 2026

Uh oh!

Beamanator commented Feb 5, 2026

Uh oh!

Beamanator commented Feb 5, 2026

Uh oh!

Krishna2323 Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

samranahm commented Dec 24, 2025 •

edited

Loading

codecov bot commented Dec 24, 2025 •

edited by github-actions bot

Loading

samranahm commented Jan 23, 2026 •

edited

Loading

Beamanator commented Feb 5, 2026 •

edited

Loading

Krishna2323 Feb 5, 2026 •

edited

Loading