Skip to content

Conversation

@jviau
Copy link
Contributor

@jviau jviau commented Jan 23, 2026

Issue describing the changes in this PR

resolves #issue_for_this_pr

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

  1. Tweaks official build signing to use minimatch, including Azure.Functions.Sdk in the signing scope
  2. Introduces 'msbuild-sdk' as option for official release
  3. Tweaks packaging to use FinalOutputPath so that it picks up the signed-in-place dll.
  4. Add BuildNumber as VersionSuffix to Azure.Functions.Sdk.

Copilot AI review requested due to automatic review settings January 23, 2026 21:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the official build/release pipeline to include the new MSBuild SDK package and adjusts packaging so signed outputs are picked up correctly.

Changes:

  • Adds msbuild-sdk as a selectable option in the official release pipeline and wires it to Azure.Functions.Sdk publishing.
  • Updates official build signing and packing steps to include Azure.Functions.Sdk outputs and packages.
  • Adjusts packaging targets to use FinalOutputPath when collecting referenced-project pack files.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
src/Azure.Functions.Sdk/Azure.Functions.Sdk.csproj Adds CI-driven VersionSuffix using $(BuildNumber) for the SDK package.
eng/ci/templates/official/jobs/build-artifacts.yml Expands signing and packing to include MSBuild SDK outputs/packages; consolidates pack step.
eng/ci/official-release.yml Adds msbuild-sdk release option and package/pattern configuration for Azure.Functions.Sdk.
eng/build/Packaging.targets Changes referenced-project pack file collection to use FinalOutputPath.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants