Skip to content

Fix method naming and call in TurnstileVerifier #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamswonder merged 3 commits into from
Aug 24, 2025
Merged

Fix method naming and call in TurnstileVerifier #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a4f633b
Fix TurnstileVerifier method naming and call
JudahSan Aug 24, 2025
3ad642d
Add exclusion for TurnstileVerifier in Naming/PredicateName cop
JudahSan Aug 24, 2025
5c2c658
Remove exclusion for TurnstileVerifier from Naming/PredicateName cop …
JudahSan Aug 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,4 @@ Style/Documentation:
Rails/LexicallyScopedActionFilter:
Exclude:
- 'app/controllers/users/sessions_controller.rb'

2 changes: 1 addition & 1 deletion app/services/turnstile_verifier.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ def verify

private

def attempt_verification?
def attempt_verification # rubocop:disable Naming/PredicateMethod
MAX_RETRIES.times do |attempt|
return true if successful?(attempt)

Expand Down