Fix method naming and call in TurnstileVerifier #123
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Renamed
attempt_verification?toattempt_verificationto accurately reflectits behavior (network call with retries and logging, not a simple predicate).
Updated the
verifymethod to call the corrected method.Problem
The mismatch between the method definition (
attempt_verification?) and its call(
attempt_verification) triggered a runtime error during user authentication:This caused signup/login requests to fail with a
500 Internal Server Error.Fix
attempt_verification?→attempt_verificationImpact