Add function to plot scaling data.#11
Conversation
b060289 to
6ecb511
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 9 +1
Lines 211 281 +70
=========================================
+ Hits 211 281 +70 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
manodeep
left a comment
There was a problem hiding this comment.
I looked through the PR and had some comments/suggestions
Do you mind adding a plot that is generated by the plotting function into the conversation - that way we will have a reference
d083ab1 to
c9be886
Compare
|
@manodeep I've addressed most of your comments in the latest commits. Can you have another look? |
micaeljtoliveira
left a comment
There was a problem hiding this comment.
@edoyango Thanks for taking care of addressing the comments and sorry for my slow response.
Now, after using the code in this PR a bit, I also have some comments and suggestions.
|
@edoyango This is all good from my side, but I can't approve the PR, as I opened it 😆 Can you approve for me? |
|
PS: Please make sure you either clean-up the git history before merging or use the squash and merge option. |
|
@manodeep done! can you approve? |
5b42c65 to
14fdca3
Compare
No description provided.