Skip to content

Conversation

@atteggiani
Copy link
Collaborator

  • Updated deployment workflow.
  • Deleted mkdocs_include_stubs_plugin from requirements.txt

@atteggiani atteggiani self-assigned this Oct 22, 2025
@atteggiani atteggiani requested a review from chrisb13 October 22, 2025 07:24
@github-actions
Copy link

github-actions bot commented Oct 22, 2025

PR Preview
🚀 Preview of PR head commit 7020d2d deployed to https://access-nri.github.io/access-esm1.6-configs/pr-previews/243
2025-10-22 20:30 AEDT
Preview generated through the Deploy to GitHub Pages workflow run 18711760077.

@atteggiani atteggiani force-pushed the davide/update_deployment_workflow branch 6 times, most recently from 8d76bb4 to 51c5b35 Compare October 22, 2025 08:11
@atteggiani atteggiani force-pushed the davide/update_deployment_workflow branch from 51c5b35 to 7020d2d Compare October 22, 2025 09:29
@chrisb13
Copy link
Contributor

Thanks @atteggiani before we merge this, perhaps it's prudent to delete the two .github files I added here:
#237
When I didn't correctly understand your suggestion?

@atteggiani
Copy link
Collaborator Author

Thanks @atteggiani before we merge this, perhaps it's prudent to delete the two .github files I added here: #237 When I didn't correctly understand your suggestion?

I think the easiest solution is to merge this, and then rebase the other PRs to main.
For #237 we can easily fix the rebase conflicts (or even use git rebase main -X theirs)

Copy link
Contributor

@chrisb13 chrisb13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, been a busy day.

I think the easiest solution is to merge this, and then rebase the other PRs to main.

Sounds good

@chrisb13 chrisb13 merged commit 49668e7 into main Oct 23, 2025
17 checks passed
@chrisb13 chrisb13 deleted the davide/update_deployment_workflow branch October 23, 2025 05:15
@chrisb13
Copy link
Contributor

chrisb13 commented Oct 23, 2025

I think the easiest solution is to merge this, and then rebase the other PRs to main.

Sounds good

Fixed all the conflicts over here via 0c490c2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants