Skip to content

Conversation

@chrisb13
Copy link
Contributor

@chrisb13 chrisb13 commented Oct 21, 2025

Following up regarding having an ESM1.6 docs meeting. This is to set a basic structure as a staring point for the ESM1.6 config docs for a meeting with @chrisb13, @ccarouge, @paigem and @rml599gh (Rachel Law).

Note that there are two main sets of docs:

I've created a starting point for both.

Additionally @anton-seaice et al. has started some notes for sea ice
#234
 
If you're interested to see what we've been doing for OM3, it's here:
https://access-om3-configs.access-hive.org.au/

We also have this document:
https://anu365.sharepoint.com/:w:/r/sites/ACCESS-NRI/_layouts/15/Doc.aspx?sourcedoc=%7BBAE387EE-8E88-46DF-B869-001DC246F14F%7D&file=ESM1.6%20config%20doc%20initial%20reflections.docx&fromShare=true&action=default&mobileredirect=true

And these two discussions:

FYI @ccarouge @paigem @anton-seaice and @Whyborn (who was interested in a starting "template")

@github-actions
Copy link

github-actions bot commented Oct 21, 2025

PR Preview
⚠️ There was an error in the pr-preview deployment.
For more information check the Actions tab.
2025-10-21 13:52 AEDT

@chrisb13 chrisb13 changed the title Fix edit URI in mkdocs configuration Creating a skeleton structure for ESM1.6 configuration docs Oct 21, 2025
@chrisb13
Copy link
Contributor Author

chrisb13 commented Oct 21, 2025

Any idea why this PR-preview isn't working @atteggiani ?

I have a feeling it's related to the plug-in that @anton-seaice is using?

  Switched to a new branch '214-main'
  branch '214-main' set up to track 'origin/214-main'.
  SITE_URL=https://access-nri.github.io/access-esm1.6-configs/pr-preview-234 mkdocs build -f mkdocs.yml -d /home/runner/work/access-esm1.6-configs/access-esm1.6-configs/website/pr-preview-234
  INFO    -  [include_stubs] 'git' version: git version 2.51.0
  INFO    -  [include_stubs] 'gh' version: gh version 2.80.0 (2025-09-23)
  https://github.com/cli/cli/releases/tag/v2.80.0
  INFO    -  [include-stubs] '-f' or '--config-file' option passed.
  INFO    -  [include-stubs] Running the command 'mkdocs build -f mkdocs.yml -d /home/runner/work/access-esm1.6-configs/access-esm1.6-configs/website/pr-preview-234' using the default mkdocs executable.
  ERROR   -  Config value 'plugins': The "mkdocs-jupyter" plugin is not installed

@chrisb13
Copy link
Contributor Author

Thanks to @rml599gh @ccarouge @paigem for having a chat yesterday, here's the notes from our meeting.
ESM1.6 config doc initial reflections.docx

We agreed that I should go ahead and create the template we fleshed out (including a few of @anton-seaice's comments).

@ccarouge will review. Then we'll merge and create a mega-issue where people can be assigned sections, with separate issues for each assigned task. (Rather like what was done here)

@atteggiani
Copy link
Collaborator

Any idea why this PR-preview isn't working @atteggiani ?

I have a feeling it's related to the plug-in that @anton-seaice is using?

  Switched to a new branch '214-main'
  branch '214-main' set up to track 'origin/214-main'.
  SITE_URL=https://access-nri.github.io/access-esm1.6-configs/pr-preview-234 mkdocs build -f mkdocs.yml -d /home/runner/work/access-esm1.6-configs/access-esm1.6-configs/website/pr-preview-234
  INFO    -  [include_stubs] 'git' version: git version 2.51.0
  INFO    -  [include_stubs] 'gh' version: gh version 2.80.0 (2025-09-23)
  https://github.com/cli/cli/releases/tag/v2.80.0
  INFO    -  [include-stubs] '-f' or '--config-file' option passed.
  INFO    -  [include-stubs] Running the command 'mkdocs build -f mkdocs.yml -d /home/runner/work/access-esm1.6-configs/access-esm1.6-configs/website/pr-preview-234' using the default mkdocs executable.
  ERROR   -  Config value 'plugins': The "mkdocs-jupyter" plugin is not installed

Yes, the root issue is that the current Deploy to GitHub Pages worfklow is outdated, it uses the same configurations from the triggering commit, which is not good.
In general I would suggest replacing it with the newer version (will also need to add this workflow for message deletion).

…ccarouge (#237 (comment)) and updating GitHub pages workflow as per @attenggiani suggestion (#237 (comment)) since pr-preview is not currently working
@github-actions
Copy link

PR Preview
🛫 The preview of PR head commit 60328f87cef3697f132c0e2ffe8140d077f5c20a is currently being deployed.
The preview URL will be available once the deployment completes.
For further details, please check the Actions tab.
2025-10-22 11:08 AEDT

@github-actions
Copy link

PR Preview
⚠️ There was an error in the pr-preview deployment.
For more information check the Actions tab.
2025-10-22 11:08 AEDT

@chrisb13
Copy link
Contributor Author

@atteggiani I think I did what you suggested (updated the two files --> 60328f8) but it still didn't work. Seems to fail on quite a few errors now:
https://github.com/ACCESS-NRI/access-esm1.6-configs/actions/runs/18701170526/job/53330105635

Feel free to just commit to this branch if you know how to fix it...

@github-actions
Copy link

PR Preview
🛫 The preview of PR head commit 3232fe02073d7d180ee95cd55ff87582a5f5eb4f is currently being deployed.
The preview URL will be available once the deployment completes.
For further details, please check the Actions tab.
2025-10-22 11:17 AEDT

@github-actions
Copy link

PR Preview
⚠️ There was an error in the pr-preview deployment.
For more information check the Actions tab.
2025-10-22 11:17 AEDT

…gs/edit/main/README.md, I would suggest we remove most of it and just re-direct to this page
@github-actions
Copy link

PR Preview
🛫 The preview of PR head commit a24b1a856cb437196ad90a626bc9513e016c9530 is currently being deployed.
The preview URL will be available once the deployment completes.
For further details, please check the Actions tab.
2025-10-22 11:24 AEDT

@github-actions
Copy link

PR Preview
⚠️ There was an error in the pr-preview deployment.
For more information check the Actions tab.
2025-10-22 11:24 AEDT

@github-actions
Copy link

PR Preview
🛫 The preview of PR head commit 19c1f2148e366e5bb78b6ceda96b1dd85ddfdb29 is currently being deployed.
The preview URL will be available once the deployment completes.
For further details, please check the Actions tab.
2025-10-22 11:32 AEDT

@github-actions
Copy link

PR Preview
⚠️ There was an error in the pr-preview deployment.
For more information check the Actions tab.
2025-10-22 11:32 AEDT

@atteggiani
Copy link
Collaborator

atteggiani commented Oct 22, 2025

@atteggiani I think I did what you suggested (updated the two files --> 60328f8) but it still didn't work. Seems to fail on quite a few errors now: https://github.com/ACCESS-NRI/access-esm1.6-configs/actions/runs/18701170526/job/53330105635

Feel free to just commit to this branch if you know how to fix it...

It should be replaced in main (not in a PR), and it should be slightly modified.

I can open a PR for it later today.

@chrisb13
Copy link
Contributor Author

@atteggiani I think I did what you suggested (updated the two files --> 60328f8) but it still didn't work. Seems to fail on quite a few errors now: https://github.com/ACCESS-NRI/access-esm1.6-configs/actions/runs/18701170526/job/53330105635
Feel free to just commit to this branch if you know how to fix it...

It should be replaced in main (not in a PR), and it should be slightly modified.

I can open a PR for it later today.

Oh okay, well I guess we could merge this if you prefer for it to go to main that way?

(I don't mind).

I just tested this locally and it builds okay so I think it's just the github stuff. Please ping me and @ccarouge when it's working :)

Copy link
Member

@ccarouge ccarouge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some more changes to make but they require I set this up locally so I'm just recording these comments for now.

@ccarouge
Copy link
Member

@atteggiani @anton-seaice I'm trying to work on these config docs locally but I get an error in mkdocs serve. Any idea about the source of the error is welcome:

$brew install --cask miniforge

$python --version
Python 3.12.11

$cd access-esm1.6-configs/

$cd documentation/

$pip install -r requirements.txt
[Install output ...]
Successfully installed GitPython-3.1.45 MarkupSafe-3.0.3 babel-2.17.0 backrefs-5.9 beautifulsoup4-4.14.2 click-8.3.0 ghp-import-2.1.0 gitdb-4.0.12 jinja2-3.1.6 latexcodec-3.0.1 markdown-3.9 mergedeep-1.3.4 mkdocs-1.6.1 mkdocs-bibtex-4.4.0 mkdocs-events-plugin-0.1 mkdocs-get-deps-0.2.0 mkdocs-git-revision-date-localized-plugin-1.2.0 mkdocs-include-stubs-plugin-1.0.2 mkdocs-macros-plugin-1.0.4 mkdocs-material-9.6.11 mkdocs-material-extensions-1.3.1 paginate-0.5.7 pathspec-0.12.1 pybtex-0.25.1 pygments-2.19.2 pymdown-extensions-10.16.1 pypandoc-1.15 pypandoc_binary-1.15 python-dateutil-2.9.0.post0 pytz-2025.2 pyyaml-6.0.3 pyyaml-env-tag-1.1 responses-0.25.8 six-1.17.0 smmap-5.0.2 soupsieve-2.8 termcolor-3.1.0 typing-extensions-4.15.0 validators-0.35.0 versioneer-0.29 watchdog-6.0.0

$mkdocs serve
INFO    -  [include_stubs] 'git' version: git version 2.39.5 (Apple Git-154)
Traceback (most recent call last):
  File "/opt/homebrew/Caskroom/miniforge/base/bin/mkdocs", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/opt/homebrew/Caskroom/miniforge/base/lib/python3.12/site-packages/include_stubs/cli.py", line 204, in main
    print_exe_version(exe)
  File "/opt/homebrew/Caskroom/miniforge/base/lib/python3.12/site-packages/include_stubs/utils.py", line 104, in print_exe_version
    version = run_command([executable, "--version"])
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Caskroom/miniforge/base/lib/python3.12/site-packages/include_stubs/utils.py", line 82, in run_command
    result = _run_command(command)
             ^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Caskroom/miniforge/base/lib/python3.12/subprocess.py", line 548, in run
    with Popen(*popenargs, **kwargs) as process:
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Caskroom/miniforge/base/lib/python3.12/subprocess.py", line 1026, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/opt/homebrew/Caskroom/miniforge/base/lib/python3.12/subprocess.py", line 1955, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'gh'

@anton-seaice
Copy link
Collaborator

I had that too, I don't remember what I did. Maybe i just installed gh ?

Its a strange error, because the stubs are not included in mkdocs.yml (although the plugin is still in the requirements.txt file). Alternatively, try uninistalling mkdocs_include_configuration_stubs_plugin

@atteggiani
Copy link
Collaborator

@ccarouge
The mkdocs_include_configuration_stubs_plugin needs gh to be installed on the system.
Either install gh, or if the plugin is not being used anymore, simply uninstall it (you will have to reinstall mkdocs afterwards though).

@chrisb13
Copy link
Contributor Author

I have some more changes to make but they require I set this up locally so I'm just recording these comments for now.

Thanks @ccarouge

I think I'd prefer to wait till @atteggiani can fix the pr-preview before rolling through these changes.

(For this kind of first hack, in future, I'd be happy for you to just commit the changes by the way.)

@github-actions
Copy link

github-actions bot commented Oct 22, 2025

PR Preview
🚀 Preview of PR head commit a887956 deployed to https://access-nri.github.io/access-esm1.6-configs/pr-previews/237
2025-10-24 11:57 AEDT
Preview generated through the Deploy to GitHub Pages workflow run 18766254508.

@chrisb13 chrisb13 mentioned this pull request Oct 22, 2025
2 tasks
@chrisb13
Copy link
Contributor Author

chrisb13 commented Oct 23, 2025

@ccarouge the PR preview is now working. Thanks @atteggiani!

Did you want to have another glance? I've applied your straightforward suggestions (with one edit)

@ccarouge
Copy link
Member

@ccarouge The mkdocs_include_configuration_stubs_plugin needs gh to be installed on the system. Either install gh, or if the plugin is not being used anymore, simply uninstall it (you will have to reinstall mkdocs afterwards though).

Shouldn't gh be listed in the requirements then?

@ccarouge
Copy link
Member

@chrisb13

(For this kind of first hack, in future, I'd be happy for you to just commit the changes by the way.)

Except for doing a review/giving feedback, I much prefer to go through the review panel provided by GitHub that doesn't allow me to commit directly. I think it allows me to make suggestions and maybe to apply them afterwards but since I hadn't finished with my feedback in this case, I didn't see the need.

@atteggiani
Copy link
Collaborator

@ccarouge The mkdocs_include_configuration_stubs_plugin needs gh to be installed on the system. Either install gh, or if the plugin is not being used anymore, simply uninstall it (you will have to reinstall mkdocs afterwards though).

Shouldn't gh be listed in the requirements then?

It's listed in mkdocs_include_configuration_stubs_plugin's requirements. There's no way to specify it in the requirements.txt because it cannot be installed through pip.
In any case, this plugin is not needed anymore, so it can be deleted from the requirements and mkdocs.yaml (it's already deleted in main).

@chrisb13
Copy link
Contributor Author

since I hadn't finished with my feedback in this case, I didn't see the need.

Oh so you're still doing your review?

My broader point is that we've already heavily discussed this so I think just make the changes you see fit and merge. It's just a starting point for others to add content.

- Removed duplicated pages
- added more model component pages
- fixed heading levels for TOC
@ccarouge
Copy link
Member

@chrisb13 (and anyone interested), I've finished with my feedback. I've realised the Word doc had duplication (both alternate structures for Inputs were written). So I've removed the duplicated stuff and some smaller updates around the TOC and model components.

I still think tabs would be nice but we don't have to decide now.

@chrisb13
Copy link
Contributor Author

@ccarouge thanks for the revisions. I think I've now addressed all your comments. Please feel free to approve and squash-merge.

@ccarouge ccarouge merged commit fecf812 into main Oct 24, 2025
15 checks passed
@chrisb13 chrisb13 deleted the 217-configdoc_restructure branch October 24, 2025 06:17
@chrisb13
Copy link
Contributor Author

Thanks for your help @ccarouge @rml599gh @anton-seaice !

@access-hive-bot
Copy link

This pull request has been mentioned on ACCESS Hive Community Forum. There might be relevant details there:

https://forum.access-hive.org.au/t/access-esm1-6-development/3114/269

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants