-
Notifications
You must be signed in to change notification settings - Fork 1
Creating a skeleton structure for ESM1.6 configuration docs #237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Any idea why this PR-preview isn't working @atteggiani ? I have a feeling it's related to the plug-in that @anton-seaice is using? Switched to a new branch '214-main'
branch '214-main' set up to track 'origin/214-main'.
SITE_URL=https://access-nri.github.io/access-esm1.6-configs/pr-preview-234 mkdocs build -f mkdocs.yml -d /home/runner/work/access-esm1.6-configs/access-esm1.6-configs/website/pr-preview-234
INFO - [include_stubs] 'git' version: git version 2.51.0
INFO - [include_stubs] 'gh' version: gh version 2.80.0 (2025-09-23)
https://github.com/cli/cli/releases/tag/v2.80.0
INFO - [include-stubs] '-f' or '--config-file' option passed.
INFO - [include-stubs] Running the command 'mkdocs build -f mkdocs.yml -d /home/runner/work/access-esm1.6-configs/access-esm1.6-configs/website/pr-preview-234' using the default mkdocs executable.
ERROR - Config value 'plugins': The "mkdocs-jupyter" plugin is not installed |
|
Thanks to @rml599gh @ccarouge @paigem for having a chat yesterday, here's the notes from our meeting. We agreed that I should go ahead and create the template we fleshed out (including a few of @anton-seaice's comments). @ccarouge will review. Then we'll merge and create a mega-issue where people can be assigned sections, with separate issues for each assigned task. (Rather like what was done here) |
Yes, the root issue is that the current Deploy to GitHub Pages worfklow is outdated, it uses the same configurations from the triggering commit, which is not good. |
…ccarouge (#237 (comment)) and updating GitHub pages workflow as per @attenggiani suggestion (#237 (comment)) since pr-preview is not currently working
|
|
|
@atteggiani I think I did what you suggested (updated the two files --> 60328f8) but it still didn't work. Seems to fail on quite a few errors now: Feel free to just commit to this branch if you know how to fix it... |
|
|
…gs/edit/main/README.md, I would suggest we remove most of it and just re-direct to this page
|
|
|
|
It should be replaced in I can open a PR for it later today. |
Oh okay, well I guess we could merge this if you prefer for it to go to main that way? (I don't mind). I just tested this locally and it builds okay so I think it's just the github stuff. Please ping me and @ccarouge when it's working :) |
ccarouge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some more changes to make but they require I set this up locally so I'm just recording these comments for now.
|
@atteggiani @anton-seaice I'm trying to work on these config docs locally but I get an error in |
|
I had that too, I don't remember what I did. Maybe i just installed gh ? Its a strange error, because the stubs are not included in |
|
@ccarouge |
Thanks @ccarouge I think I'd prefer to wait till @atteggiani can fix the pr-preview before rolling through these changes. (For this kind of first hack, in future, I'd be happy for you to just commit the changes by the way.) |
|
Co-authored-by: Claire Carouge <[email protected]>
|
@ccarouge the PR preview is now working. Thanks @atteggiani! Did you want to have another glance? I've applied your straightforward suggestions (with one edit) |
Shouldn't |
Except for doing a review/giving feedback, I much prefer to go through the review panel provided by GitHub that doesn't allow me to commit directly. I think it allows me to make suggestions and maybe to apply them afterwards but since I hadn't finished with my feedback in this case, I didn't see the need. |
It's listed in mkdocs_include_configuration_stubs_plugin's requirements. There's no way to specify it in the requirements.txt because it cannot be installed through |
Oh so you're still doing your review? My broader point is that we've already heavily discussed this so I think just make the changes you see fit and merge. It's just a starting point for others to add content. |
- Removed duplicated pages - added more model component pages - fixed heading levels for TOC
|
@chrisb13 (and anyone interested), I've finished with my feedback. I've realised the Word doc had duplication (both alternate structures for Inputs were written). So I've removed the duplicated stuff and some smaller updates around the TOC and model components. I still think tabs would be nice but we don't have to decide now. |
|
@ccarouge thanks for the revisions. I think I've now addressed all your comments. Please feel free to approve and squash-merge. |
|
Thanks for your help @ccarouge @rml599gh @anton-seaice ! |
|
This pull request has been mentioned on ACCESS Hive Community Forum. There might be relevant details there: https://forum.access-hive.org.au/t/access-esm1-6-development/3114/269 |
Following up regarding having an ESM1.6 docs meeting. This is to set a basic structure as a staring point for the ESM1.6 config docs for a meeting with @chrisb13, @ccarouge, @paigem and @rml599gh (Rachel Law).
Note that there are two main sets of docs:
I've created a starting point for both.
Additionally @anton-seaice et al. has started some notes for sea ice
#234
If you're interested to see what we've been doing for OM3, it's here:
https://access-om3-configs.access-hive.org.au/
We also have this document:
https://anu365.sharepoint.com/:w:/r/sites/ACCESS-NRI/_layouts/15/Doc.aspx?sourcedoc=%7BBAE387EE-8E88-46DF-B869-001DC246F14F%7D&file=ESM1.6%20config%20doc%20initial%20reflections.docx&fromShare=true&action=default&mobileredirect=true
And these two discussions:
FYI @ccarouge @paigem @anton-seaice and @Whyborn (who was interested in a starting "template")