Skip to content

fix: loadConfig function should work in browser #2262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
AlexVarchuk wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix: loadConfig function should work in browser #2262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50e1bfd
fix: loadConfig function should work in browser
AlexVarchuk Aug 14, 2025
545c06f
chore: add changeset
AlexVarchuk Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/popular-tomatoes-draw.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@redocly/openapi-core": patch
---

Improved browser compatibility for `loadConfig`.
7 changes: 2 additions & 5 deletions packages/core/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import * as fs from 'node:fs';
import * as path from 'node:path';
import { minimatch } from 'minimatch';
import pluralizeOne from 'pluralize';
import { parseYaml } from './js-yaml/index.js';
Expand Down Expand Up @@ -212,10 +211,8 @@ export function isCustomRuleId(id: string) {
}

export function doesYamlFileExist(filePath: string): boolean {
return (
(path.extname(filePath) === '.yaml' || path.extname(filePath) === '.yml') &&
!!fs?.existsSync?.(filePath)
);
const ext = filePath.substr(filePath.lastIndexOf('.'));
Copy link
Collaborator

@tatomyr tatomyr Aug 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The substr is deprecated already. Also, this doesn't handle the case when a file is named file or .env. It would be better to create a utility function and write a couple of tests for it.

return (ext === '.yaml' || ext === '.yml') && !!fs?.existsSync?.(filePath);
}

export type Falsy = undefined | null | false | '' | 0;
Expand Down
Loading