fix: loadConfig function should work in browser #2262
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 545c06f The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
JLekawa
approved these changes
Aug 14, 2025
tatomyr
reviewed
Aug 15, 2025
| (path.extname(filePath) === '.yaml' || path.extname(filePath) === '.yml') && | ||
| !!fs?.existsSync?.(filePath) | ||
| ); | ||
| const ext = filePath.substr(filePath.lastIndexOf('.')); |
Collaborator
There was a problem hiding this comment.
The substr is deprecated already. Also, this doesn't handle the case when a file is named file or .env. It would be better to create a utility function and write a couple of tests for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why/How?
When using
loadConfigfunction to get the config for the browser environment, we get an error: "path.extnameis not a function"Reference
Testing
Screenshots (optional)
Check yourself
Security