chore: Add turboFilter to enhance the infinispan debug message#4567
Open
chore: Add turboFilter to enhance the infinispan debug message#4567
Conversation
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
arxioly
reviewed
Apr 14, 2026
| if (marker != null && APIML_MARKER.equals(marker.getName())) { | ||
| return FilterReply.NEUTRAL; | ||
| } | ||
| if (logger.getName().equals(TARGET_LOGGER) && format != null && format.contains("File") && format.contains("not found")) { |
Contributor
There was a problem hiding this comment.
What about using matches instead of twice contains?
Suggested change
| if (logger.getName().equals(TARGET_LOGGER) && format != null && format.contains("File") && format.contains("not found")) { | |
| if (logger.getName().equals(TARGET_LOGGER) && format != null && format.matches("File \\d not found")) { |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Add Logback TurboFilter to enhance the infinispan debug message that occurs when Infinispan fails to open or access a cache segment file (index) in
org.infinispan.persistence.sifs.FileProvider. The filter will intercept the message, and enhance it by appending a new Zowe message codeZWECS137Wthat will be documented in the troubleshooting section.Note: Since logback is triggered before Spring, we cannot leverage the
org.zowe.apiml.message.log.ApimlLoggerTherefore, we have to use Slf4j, but we still document the
ZWECS137Wmessage under keyorg.zowe.apiml.cache.errorOpeningCachingFiles, so it will be reflected in Zowe doc.Linked to # (issue)
Part of the # (epic)
Type of change
Please delete options that are not relevant.
Checklist:
For more details about how should the code look like read the Contributing guideline