-
Notifications
You must be signed in to change notification settings - Fork 37
Update root hints after B-root renumbering #1490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/v2025.2.1
Are you sure you want to change the base?
Update root hints after B-root renumbering #1490
Conversation
Merge pull request zonemaster#1483 from zonemaster/develop
Update the built-in root hints file: this hasn’t been done in three years, and b.root-servers.net’s IP addresses have changed since (see [1]). This is to make sure that we don’t send traffic to IP addresses belonging to _former_ root servers (see for example [2] for the case of J-root). I think this also reveals an oversight in our release procedure: we ought to make sure that every release of Zonemaster ships with a fresh and up-to-date root hints file. I don’t think this is currently the case. Unit test data needs to be rerecorded as well. This is done except for t/old-bugs.data; that file cannot be updated easily. [1]: https://b.root-servers.org/news/2023/05/16/new-addresses.html [2]: https://indico.dns-oarc.net/event/55/contributions/1176/attachments/1134/2372/wessels-oarc45-oldjroot.pdf
4bdf69a to
6b00d65
Compare
|
Unit tests will still fail because |
tgreenx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. May be a candidate for v2025.2.1 (milestone to be created).
|
CI fails, but I cannot see why. |
I had to rerecord some of the t/*.data files because of the renumbering. But one data file that I cannot rerecord is t/old-bugs.data. Therefore, t/old-bugs.t still fails, which causes the entire CI pipeline to fail. If we merge #1487 then rebase this PR on top of that, the CI should pass again. |
To which branch, develop or release/v2025.2.1? See my message in Slack. |
I propose we merge to release/v2025.2.1. |
Purpose
This PR updates the root hints, with the new IP addresses for B-root.
Context
Fixes #1489.
Changes
How to test this PR
Unit tests should still pass.