Skip to content

Conversation

@ReFil
Copy link
Contributor

@ReFil ReFil commented Jan 14, 2026

With the binding referenced to as uint8_t the keymap would be incorrect if more than 256 positions were in use as they would overflow back to position 0, going to a uint16_t gives a significantly improved headroom

PR check-list

  • Branch has a clean commit history
  • Additional tests are included, if changing behaviors/core code that is testable.
  • Proper Copyright + License headers added to applicable files (Generally, we stick to "The ZMK Contributors" for copyrights to help avoid churn when files get edited)
  • Pre-commit used to check formatting of files, commit messages, etc.
  • Includes any necessary documentation changes.

With the binding referenced to as uint8_t the keymap would be incorrect if more than 256 positions were in use, going to a uint16_t gives large enough headroom to not have to worry
@ReFil ReFil requested a review from a team as a code owner January 14, 2026 23:07
Copy link
Contributor

@petejohanson petejohanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@petejohanson petejohanson merged commit ab46f48 into zmkfirmware:main Jan 16, 2026
50 checks passed
@petejohanson petejohanson modified the milestone: 0.0.1 Jan 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants